From 4a99615a609eec2b84bb2341d74fac46a5998137 Mon Sep 17 00:00:00 2001 From: Tor Andersson Date: Mon, 25 Jun 2018 13:15:50 +0200 Subject: Pass rect and matrix by value in geometry functions. Several things irk me about passing values as const pointers: * They can be NULL, which is not a valid value. * They require explicit temporary variables for storage. * They don't compose easily in a legible manner, requiring weird pointer passing semantics where the variable being assigned is hidden as an argument in the innermost function call. * We can't change the value through the pointer, requiring yet more local variables to hold copies of the input value. In the device interface where we pass a matrix to a function, we often find ourselves making a local copy of the matrix so we can concatenate other transforms to it. This copying is a lot of unnecessary busywork that I hope to eventually avoid by laying the groundwork with this commit. This is a rather large API change, so I apologize for the inconvenience, but I hope the end result and gain in legibility will be worth the pain. --- source/gprf/gprf-skeleton.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source/gprf/gprf-skeleton.c') diff --git a/source/gprf/gprf-skeleton.c b/source/gprf/gprf-skeleton.c index f70e82a5..1901c171 100644 --- a/source/gprf/gprf-skeleton.c +++ b/source/gprf/gprf-skeleton.c @@ -38,7 +38,7 @@ fz_save_gproof(fz_context *ctx, const char *pdf_file, fz_document *doc, const ch int w, h; page = fz_load_page(ctx, doc, i); - fz_bound_page(ctx, page, &rect); + rect = fz_bound_page(ctx, page); fz_drop_page(ctx, page); page = NULL; -- cgit v1.2.3