diff options
| author | Jochen Eisinger <jochen@chromium.org> | 2015-07-15 14:47:01 +0200 |
|---|---|---|
| committer | Jochen Eisinger <jochen@chromium.org> | 2015-07-15 14:47:01 +0200 |
| commit | 8ccc2068013dffd6762cb7f27238b401b9f2ffaf (patch) | |
| tree | 1ef48c5f92998f1820ba1e251c236e52558a8289 | |
| parent | 1c79928b4ade95806d0351a21b4d4727d6c8ed38 (diff) | |
| download | pdfium-8ccc2068013dffd6762cb7f27238b401b9f2ffaf.tar.xz | |
Revert "Pump the v8 message loop in tests"
This reverts commit 304578020122cc4d2a4a8c1598694ef2b9be92b5.
Turns out that in both cases v8 is already destructed at those points,
and we can't pump the message loops.
TBR=tsepez@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1236603003 .
| -rw-r--r-- | samples/pdfium_test.cc | 2 | ||||
| -rw-r--r-- | testing/embedder_test.cpp | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc index 8ca26abd05..7e9ca68cef 100644 --- a/samples/pdfium_test.cc +++ b/samples/pdfium_test.cc @@ -616,8 +616,6 @@ int main(int argc, const char* argv[]) { if (!file_contents) continue; RenderPdf(filename, file_contents, file_length, options); - while (v8::platform::PumpMessageLoop(platform, v8::Isolate::GetCurrent())) - continue; free(file_contents); } diff --git a/testing/embedder_test.cpp b/testing/embedder_test.cpp index 6d9907eb7e..02d0fae789 100644 --- a/testing/embedder_test.cpp +++ b/testing/embedder_test.cpp @@ -173,8 +173,6 @@ void EmbedderTest::TearDown() { FPDF_CloseDocument(document_); FPDFDOC_ExitFormFillEnvironment(form_handle_); } - while (v8::platform::PumpMessageLoop(platform_, v8::Isolate::GetCurrent())) - continue; FPDFAvail_Destroy(avail_); FPDF_DestroyLibrary(); v8::V8::ShutdownPlatform(); |