summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2015-09-15 17:08:15 -0700
committerLei Zhang <thestig@chromium.org>2015-09-15 17:08:15 -0700
commit005b6af7924e44f28eab2c5228fd9eb2538a6c3e (patch)
treee9478b424cbbc25aafdd372ff1c61a7cc882f0c0
parent4ec709d97e01f0a7ded849986f535219e5383f06 (diff)
downloadpdfium-005b6af7924e44f28eab2c5228fd9eb2538a6c3e.tar.xz
Merge to M46: Fix JS_GetArrayElement to not return an empty handle on success
BUG=chromium:528376 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/1337433002 . (cherry picked from commit 0d0935d3d6603dd7d851b1d5828635230f4c43ca) Review URL: https://codereview.chromium.org/1342333002 .
-rw-r--r--fpdfsdk/src/jsapi/fxjs_v8.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/fpdfsdk/src/jsapi/fxjs_v8.cpp b/fpdfsdk/src/jsapi/fxjs_v8.cpp
index b71cee6bcc..ba65d30755 100644
--- a/fpdfsdk/src/jsapi/fxjs_v8.cpp
+++ b/fpdfsdk/src/jsapi/fxjs_v8.cpp
@@ -766,7 +766,7 @@ v8::Local<v8::Value> JS_GetArrayElement(IJS_Runtime* pJSRuntime,
if (pArray.IsEmpty())
return v8::Local<v8::Value>();
v8::Local<v8::Value> val;
- if (pArray->Get(pJSRuntime->GetCurrentContext(), index).ToLocal(&val))
+ if (!pArray->Get(pJSRuntime->GetCurrentContext(), index).ToLocal(&val))
return v8::Local<v8::Value>();
return val;
}