diff options
author | Dirk Pranke <dpranke@chromium.org> | 2015-05-01 14:26:13 -0700 |
---|---|---|
committer | Dirk Pranke <dpranke@chromium.org> | 2015-05-01 14:26:13 -0700 |
commit | 5aaa603e120d84cbaf74a29484d63ec0bbbce87e (patch) | |
tree | 3bd86d93db9abe39522c7d94c12dc53aae5a755e | |
parent | c4631925ccd0ba4d471f5beed2d20a1a6de9368e (diff) | |
download | pdfium-5aaa603e120d84cbaf74a29484d63ec0bbbce87e.tar.xz |
Adjust the visibility of the standalone targets in the GN build.
As part of the migration from GYP->GN, we want to make sure that we
can track when new targets are added to either the GYP or GN builds
and that we are building everything we expect to build.
In GN, unlike GYP, if a build file gets referenced from other files,
building 'all' will cause every target to be built in it. This means in
particular, that we can end up trying to build targets that are not
necessarily intended to be visible to the rest of the build. To get
around this, any target that is defined but hidden (like 'pdfium_unittests',
) should still be visible to a top-level target called
"//:gn_visibility".
R=tsepez@chromium.org, brettw@chromium.org
BUG=461019
Review URL: https://codereview.chromium.org/1120183002
-rw-r--r-- | BUILD.gn | 8 |
1 files changed, 6 insertions, 2 deletions
@@ -135,8 +135,12 @@ static_library("pdfium") { } } -# Targets below this are only visible within this file. -visibility = [ ":*" ] +# Targets below this are only visible within this file (and to the +# top-level gn_visibility target used to help gn_all build everything). +visibility = [ + ":*", + "//:gn_visibility", +] static_library("fdrm") { sources = [ |