diff options
| author | Lei Zhang <thestig@chromium.org> | 2015-10-30 10:31:03 -0700 |
|---|---|---|
| committer | Lei Zhang <thestig@chromium.org> | 2015-10-30 10:31:03 -0700 |
| commit | 4793f674f29be8bf06a60672032e2e2df5164c8c (patch) | |
| tree | 7f24ea4f72c7819eed386545569fdbab9f8643f6 | |
| parent | d78704258f04d947d4f5fc2a7f8b44b57d456597 (diff) | |
| download | pdfium-4793f674f29be8bf06a60672032e2e2df5164c8c.tar.xz | |
Add standard "Must be after no_chromium_code" comment in GN files.
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1411563004 .
| -rw-r--r-- | BUILD.gn | 3 | ||||
| -rw-r--r-- | third_party/BUILD.gn | 3 |
2 files changed, 4 insertions, 2 deletions
@@ -554,8 +554,7 @@ static_library("fxge") { configs += [ ":pdfium_config", "//build/config/compiler:no_chromium_code", - # As of this writing, this needs to be last to suppress a -Wswitch warning. - # https://crbug.com/547906 + # Must be after no_chromium_code for warning flags to be ordered correctly. ":fxge_warnings", ] diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn index f6358147be..e9e50cd0b9 100644 --- a/third_party/BUILD.gn +++ b/third_party/BUILD.gn @@ -46,6 +46,7 @@ static_library("fx_freetype") { configs += [ "//build/config/compiler:no_chromium_code", "//third_party/pdfium:pdfium_config", + # Must be after no_chromium_code for warning flags to be ordered correctly. ":fx_freetype_warnings", ] defines = [ "FT2_BUILD_LIBRARY" ] @@ -95,6 +96,7 @@ source_set("fx_agg") { configs += [ "//build/config/compiler:no_chromium_code", "//third_party/pdfium:pdfium_config", + # Must be after no_chromium_code for warning flags to be ordered correctly. ":fx_agg_warnings", ] sources = [ @@ -134,6 +136,7 @@ source_set("fx_lcms2") { configs += [ "//build/config/compiler:no_chromium_code", "//third_party/pdfium:pdfium_config", + # Must be after no_chromium_code for warning flags to be ordered correctly. ":fx_lcms2_warnings", ] sources = [ |