summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJun Fang <jun_fang@foxitsoftware.com>2015-12-10 18:29:34 -0800
committerJun Fang <jun_fang@foxitsoftware.com>2015-12-10 18:29:34 -0800
commitc7c3f124fb4ece9a1e09ef16058c2f51947bf714 (patch)
tree40ce09a8f51c7983f05c48322447ee10d60b2e51
parentb9882f4fbcc5f6a9cea49f5c2ec6b91aafac1032 (diff)
downloadpdfium-c7c3f124fb4ece9a1e09ef16058c2f51947bf714.tar.xz
Fix crashing in CFWL_CheckBox::Initialize()
BUG=pdfium:324 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1507683010 .
-rw-r--r--xfa/src/fwl/src/lightwidget/checkbox.cpp8
1 files changed, 2 insertions, 6 deletions
diff --git a/xfa/src/fwl/src/lightwidget/checkbox.cpp b/xfa/src/fwl/src/lightwidget/checkbox.cpp
index 37aeb087f1..b1b938435b 100644
--- a/xfa/src/fwl/src/lightwidget/checkbox.cpp
+++ b/xfa/src/fwl/src/lightwidget/checkbox.cpp
@@ -14,12 +14,8 @@ FWL_ERR CFWL_CheckBox::Initialize(const CFWL_WidgetProperties* pProperties) {
if (pProperties) {
*m_pProperties = *pProperties;
}
- CFWL_WidgetImpProperties prop =
- m_pProperties->MakeWidgetImpProperties(&m_checkboxData);
- prop.m_pParent = m_pProperties->m_pParent->GetWidget();
- prop.m_pOwner = m_pProperties->m_pOwner->GetWidget();
- nonstd::unique_ptr<IFWL_CheckBox> pCheckBox(
- IFWL_CheckBox::Create(prop, nullptr));
+ nonstd::unique_ptr<IFWL_CheckBox> pCheckBox(IFWL_CheckBox::Create(
+ m_pProperties->MakeWidgetImpProperties(&m_checkboxData), nullptr));
FWL_ERR ret = pCheckBox->Initialize();
if (ret != FWL_ERR_Succeeded) {
return ret;