diff options
| author | Lei Zhang <thestig@chromium.org> | 2015-12-28 13:12:26 -0800 |
|---|---|---|
| committer | Lei Zhang <thestig@chromium.org> | 2015-12-28 13:12:26 -0800 |
| commit | d77f03faf713c071846cf178b3cf801b230db930 (patch) | |
| tree | fced98fa87386240e495e8cc31463067b7f6e311 | |
| parent | 6b37a5fd73775bb35d26dff5a00f0f1a3f0f582b (diff) | |
| download | pdfium-d77f03faf713c071846cf178b3cf801b230db930.tar.xz | |
Merge to XFA: Take care fall-through cases of switch in pdfium
Found with Clang's -Wimplicit-fallthrough option by tzik@chromium.org.
TBR=tzik@chromium.org
Review URL: https://codereview.chromium.org/1549283002 .
(cherry picked from commit de0387c3690ca147482ed943c70eeb828b6dd732)
Review URL: https://codereview.chromium.org/1554453002 .
| -rw-r--r-- | fpdfsdk/src/formfiller/FFL_FormFiller.cpp | 2 | ||||
| -rw-r--r-- | fpdfsdk/src/javascript/JS_GlobalData.cpp | 4 |
2 files changed, 4 insertions, 2 deletions
diff --git a/fpdfsdk/src/formfiller/FFL_FormFiller.cpp b/fpdfsdk/src/formfiller/FFL_FormFiller.cpp index 0e74d91fab..a903824c6a 100644 --- a/fpdfsdk/src/formfiller/FFL_FormFiller.cpp +++ b/fpdfsdk/src/formfiller/FFL_FormFiller.cpp @@ -273,8 +273,10 @@ void CFFL_FormFiller::KillFocusForAnnot(CPDFSDK_Annot* pAnnot, FX_UINT nFlag) { case FIELDTYPE_CHECKBOX: case FIELDTYPE_RADIOBUTTON: bDestroyPDFWindow = TRUE; + break; default: bDestroyPDFWindow = FALSE; + break; } EscapeFiller(pPageView, bDestroyPDFWindow); } diff --git a/fpdfsdk/src/javascript/JS_GlobalData.cpp b/fpdfsdk/src/javascript/JS_GlobalData.cpp index 474886c484..4d6edc898d 100644 --- a/fpdfsdk/src/javascript/JS_GlobalData.cpp +++ b/fpdfsdk/src/javascript/JS_GlobalData.cpp @@ -51,13 +51,13 @@ void CJS_GlobalVariableArray::Copy(const CJS_GlobalVariableArray& array) { pNewObjData->nType = pOldObjData->nType; pNewObjData->objData.Copy(pOldObjData->objData); Add(pNewObjData); - } + } break; case JS_GLOBALDATA_TYPE_NULL: { CJS_KeyValue* pNewObjData = new CJS_KeyValue; pNewObjData->sKey = pOldObjData->sKey; pNewObjData->nType = pOldObjData->nType; Add(pNewObjData); - } + } break; } } } |