diff options
| author | jochen <jochen@chromium.org> | 2016-07-07 04:31:26 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-07-07 04:31:26 -0700 |
| commit | 3c27a84d15c06f85cc7f455f96dc124673f9f9d2 (patch) | |
| tree | 8f15f79c3e9c2ac173fff7ffd66fe956be754bc5 | |
| parent | 9a53675a6834d9ca82ac7b593123078de3748e11 (diff) | |
| download | pdfium-chromium/2794.tar.xz | |
Remove constructor from functions that aren't constructorschromium/2796chromium/2795chromium/2794chromium/2793chromium/2792chromium/2791
BUG=chromium:625823
R=haraken@chromium.org,thestig@chromium.org
Review-Url: https://codereview.chromium.org/2128793002
| -rw-r--r-- | DEPS | 2 | ||||
| -rw-r--r-- | fxjse/dynprop.cpp | 8 |
2 files changed, 6 insertions, 4 deletions
@@ -18,7 +18,7 @@ vars = { 'skia_revision': '7942f22c607caf826a6a609b89338a569d0a30e7', 'tools_memory_revision': '427f10475e1a8d72424c29d00bf689122b738e5d', 'trace_event_revision': '54b8455be9505c2cb0cf5c26bb86739c236471aa', - 'v8_revision': '820a23aade5e74a92d794e05a0c2b3597f0da4b5', + 'v8_revision': '453b746d88e3d047d3f6c4363f0fe42b6bd13638', } deps = { diff --git a/fxjse/dynprop.cpp b/fxjse/dynprop.cpp index 34f63f4338..836cd5f25a 100644 --- a/fxjse/dynprop.cpp +++ b/fxjse/dynprop.cpp @@ -57,9 +57,11 @@ static void FXJSE_DynPropGetterAdapter(const FXJSE_CLASS_DESCRIPTOR* lpClass, 1, v8::String::NewFromUtf8( pIsolate, reinterpret_cast<const char*>(szPropName.raw_str()), v8::String::kNormalString, szPropName.GetLength())); - pValue->ForceSetValue(v8::Function::New( - pValue->GetIsolate(), FXJSE_DynPropGetterAdapter_MethodCallback, - hCallBackInfo)); + pValue->ForceSetValue( + v8::Function::New(pValue->GetIsolate()->GetCurrentContext(), + FXJSE_DynPropGetterAdapter_MethodCallback, + hCallBackInfo, 0, v8::ConstructorBehavior::kThrow) + .ToLocalChecked()); } } } |