summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorweili <weili@chromium.org>2016-05-17 10:16:40 -0700
committerCommit bot <commit-bot@chromium.org>2016-05-17 10:16:40 -0700
commit59ce240d509a3079dab64f891a5363b11d4de3c7 (patch)
tree2ab6d2b80df49bbd4e1fd83ac7265f4231f142bc
parentdbc14facb99d7b6e9af5dd76f036b7bf59705b2f (diff)
downloadpdfium-59ce240d509a3079dab64f891a5363b11d4de3c7.tar.xz
Fix DrMemory bot error by properly initializing the variable
The variable needs to be initialized before using. Review-Url: https://codereview.chromium.org/1984323002
-rw-r--r--core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp2
-rw-r--r--core/fpdfapi/fpdf_edit/include/cpdf_creator.h1
2 files changed, 3 insertions, 0 deletions
diff --git a/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp b/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
index 372506d6cc..658b9782e5 100644
--- a/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
+++ b/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
@@ -881,7 +881,9 @@ CPDF_Creator::CPDF_Creator(CPDF_Document* pDoc)
m_bSecurityChanged(FALSE),
m_pEncryptDict(m_pParser ? m_pParser->GetEncryptDict() : nullptr),
m_dwEncryptObjNum(0),
+ m_bEncryptCloned(FALSE),
m_pCryptoHandler(m_pParser ? m_pParser->GetCryptoHandler() : nullptr),
+ m_bLocalCryptoHandler(FALSE),
m_pMetadata(nullptr),
m_ObjectStreamSize(200),
m_dwLastObjNum(m_pDocument->GetLastObjNum()),
diff --git a/core/fpdfapi/fpdf_edit/include/cpdf_creator.h b/core/fpdfapi/fpdf_edit/include/cpdf_creator.h
index c932dc0804..8782c54f86 100644
--- a/core/fpdfapi/fpdf_edit/include/cpdf_creator.h
+++ b/core/fpdfapi/fpdf_edit/include/cpdf_creator.h
@@ -80,6 +80,7 @@ class CPDF_Creator {
uint32_t m_dwEncryptObjNum;
FX_BOOL m_bEncryptCloned;
CPDF_CryptoHandler* m_pCryptoHandler;
+ // Whether this owns the crypto handler |m_pCryptoHandler|.
FX_BOOL m_bLocalCryptoHandler;
CPDF_Object* m_pMetadata;
std::unique_ptr<CPDF_XRefStream> m_pXRefStream;