diff options
| author | Miklos Vajna <vmiklos@vmiklos.hu> | 2017-02-25 14:44:57 +0100 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-02-26 00:00:45 +0000 |
| commit | f2225817ddbe05e2caa751da23c4a6d44c5160bd (patch) | |
| tree | 86ee9b8c0485198cd84dc9fcdf9e199702045a4f | |
| parent | 412fa65331cc04776bf1e3da5f51f29ea0fc7937 (diff) | |
| download | pdfium-f2225817ddbe05e2caa751da23c4a6d44c5160bd.tar.xz | |
core: fix two more uninitialized memberschromium/3025chromium/3024
Found by Coverity when scanning the bundled pdfium-3004 in LibreOffice.
This fixes:
- CID 1400335: Uninitialized members (UNINIT_CTOR)
CPDF_DataAvail::m_dwTrailerOffset
- CID 1400334: Uninitialized members (UNINIT_CTOR)
CXML_Element::m_pParent
Change-Id: I42da9a704ad75adf39c510c6ef89eb7a97860ea1
Reviewed-on: https://pdfium-review.googlesource.com/2670
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
| -rw-r--r-- | AUTHORS | 1 | ||||
| -rw-r--r-- | core/fpdfapi/parser/cpdf_data_avail.cpp | 1 | ||||
| -rw-r--r-- | core/fxcrt/fx_xml.h | 2 | ||||
| -rw-r--r-- | core/fxcrt/fx_xml_parser.cpp | 13 |
4 files changed, 4 insertions, 13 deletions
@@ -27,6 +27,7 @@ Lei Zhang <thestig@chromium.org> Lucas Nihlen <luken@chromium.org> Matt Giuca <mgiuca@chromium.org> Michael Doppler <m.doppler@gmail.com> +Miklos Vajna <vmiklos@vmiklos.hu> Nico Weber <thakis@chromium.org> Peter Kasting <pkasting@chromium.org> Raymes Khoury <raymes@chromium.org> diff --git a/core/fpdfapi/parser/cpdf_data_avail.cpp b/core/fpdfapi/parser/cpdf_data_avail.cpp index 4205ed2456..c6ecae9b1d 100644 --- a/core/fpdfapi/parser/cpdf_data_avail.cpp +++ b/core/fpdfapi/parser/cpdf_data_avail.cpp @@ -46,6 +46,7 @@ CPDF_DataAvail::CPDF_DataAvail( } m_dwCurrentOffset = 0; m_dwXRefOffset = 0; + m_dwTrailerOffset = 0; m_bufferOffset = 0; m_bufferSize = 0; m_PagesObjNum = 0; diff --git a/core/fxcrt/fx_xml.h b/core/fxcrt/fx_xml.h index 7f42a7fa9b..38a1b60846 100644 --- a/core/fxcrt/fx_xml.h +++ b/core/fxcrt/fx_xml.h @@ -66,8 +66,6 @@ class CXML_Element { bool bSaveSpaceChars = false, FX_FILESIZE* pParsedSize = nullptr); - CXML_Element(const CFX_ByteStringC& qSpace, const CFX_ByteStringC& tagName); - explicit CXML_Element(const CFX_ByteStringC& qTagName); CXML_Element(); ~CXML_Element(); diff --git a/core/fxcrt/fx_xml_parser.cpp b/core/fxcrt/fx_xml_parser.cpp index 7658620424..2250087b61 100644 --- a/core/fxcrt/fx_xml_parser.cpp +++ b/core/fxcrt/fx_xml_parser.cpp @@ -715,17 +715,8 @@ CXML_Element* CXML_Element::Parse( return XML_ContinueParse(parser, bSaveSpaceChars, pParsedSize); } -CXML_Element::CXML_Element() : m_QSpaceName(), m_TagName(), m_AttrMap() {} -CXML_Element::CXML_Element(const CFX_ByteStringC& qSpace, - const CFX_ByteStringC& tagName) - : m_QSpaceName(), m_TagName(), m_AttrMap() { - m_QSpaceName = qSpace; - m_TagName = tagName; -} -CXML_Element::CXML_Element(const CFX_ByteStringC& qTagName) - : m_pParent(nullptr), m_QSpaceName(), m_TagName(), m_AttrMap() { - SetTag(qTagName); -} +CXML_Element::CXML_Element() + : m_pParent(nullptr), m_QSpaceName(), m_TagName(), m_AttrMap() {} CXML_Element::~CXML_Element() { Empty(); } |