diff options
| author | Miklos Vajna <vmiklos@vmiklos.hu> | 2017-02-10 08:48:17 +0100 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-02-13 15:11:08 +0000 |
| commit | 5fb0ad8adac5fcbf8c8f1965164f41d11c0af669 (patch) | |
| tree | 2909b67c25ecb262ec4e2c6f03a03e4058bdcadc | |
| parent | 2eb1a705c243b2d5ab912268dd453f5ade075b6f (diff) | |
| download | pdfium-5fb0ad8adac5fcbf8c8f1965164f41d11c0af669.tar.xz | |
core: fix a few uninitialized members
Found by Coverity when scanning the bundled pdfium-3004 in LibreOffice.
This fixes:
- CID 1400341: Uninitialized members (UNINIT_CTOR)
CFX_ImageRenderer::m_pIccTransform
- CID 1400340: Uninitialized members (UNINIT_CTOR)
CPDF_CharPosList::m_nChars
- CID 1400339: Uninitialized members (UNINIT_CTOR)
CPDF_StreamContentParser::m_PathStartX/Y
- CID 1400337: Uninitialized members (UNINIT_CTOR)
CFX_ScanlineCompositor::m_pIccTransform
Change-Id: Iab3862eb77be8bf379093a47f6c60ce987099982
Reviewed-on: https://pdfium-review.googlesource.com/2630
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
| -rw-r--r-- | core/fpdfapi/page/cpdf_streamcontentparser.cpp | 2 | ||||
| -rw-r--r-- | core/fpdfapi/render/cpdf_charposlist.cpp | 1 | ||||
| -rw-r--r-- | core/fxge/dib/fx_dib_composite.cpp | 1 | ||||
| -rw-r--r-- | core/fxge/dib/fx_dib_main.cpp | 1 |
4 files changed, 5 insertions, 0 deletions
diff --git a/core/fpdfapi/page/cpdf_streamcontentparser.cpp b/core/fpdfapi/page/cpdf_streamcontentparser.cpp index 93478de174..21b13772c5 100644 --- a/core/fpdfapi/page/cpdf_streamcontentparser.cpp +++ b/core/fpdfapi/page/cpdf_streamcontentparser.cpp @@ -265,6 +265,8 @@ CPDF_StreamContentParser::CPDF_StreamContentParser( m_pPathPoints(nullptr), m_PathPointCount(0), m_PathAllocSize(0), + m_PathStartX(0.0f), + m_PathStartY(0.0f), m_PathCurrentX(0.0f), m_PathCurrentY(0.0f), m_PathClipType(0), diff --git a/core/fpdfapi/render/cpdf_charposlist.cpp b/core/fpdfapi/render/cpdf_charposlist.cpp index 4857b93498..05f441cc0f 100644 --- a/core/fpdfapi/render/cpdf_charposlist.cpp +++ b/core/fpdfapi/render/cpdf_charposlist.cpp @@ -11,6 +11,7 @@ CPDF_CharPosList::CPDF_CharPosList() { m_pCharPos = nullptr; + m_nChars = 0; } CPDF_CharPosList::~CPDF_CharPosList() { diff --git a/core/fxge/dib/fx_dib_composite.cpp b/core/fxge/dib/fx_dib_composite.cpp index e3dc7404f3..072ebbddd5 100644 --- a/core/fxge/dib/fx_dib_composite.cpp +++ b/core/fxge/dib/fx_dib_composite.cpp @@ -4014,6 +4014,7 @@ CFX_ScanlineCompositor::CFX_ScanlineCompositor() { m_CacheSize = 0; m_bRgbByteOrder = false; m_BlendType = FXDIB_BLEND_NORMAL; + m_pIccTransform = nullptr; } CFX_ScanlineCompositor::~CFX_ScanlineCompositor() { diff --git a/core/fxge/dib/fx_dib_main.cpp b/core/fxge/dib/fx_dib_main.cpp index 8e6366d5c0..96cae9d4e7 100644 --- a/core/fxge/dib/fx_dib_main.cpp +++ b/core/fxge/dib/fx_dib_main.cpp @@ -1471,6 +1471,7 @@ void CFX_FilteredDIB::DownSampleScanline(int line, CFX_ImageRenderer::CFX_ImageRenderer() { m_Status = 0; + m_pIccTransform = nullptr; m_bRgbByteOrder = false; m_BlendType = FXDIB_BLEND_NORMAL; } |