diff options
| author | Wei Li <weili@chromium.org> | 2016-03-29 17:15:44 -0700 |
|---|---|---|
| committer | Wei Li <weili@chromium.org> | 2016-03-29 17:15:44 -0700 |
| commit | 85ff9870a48e3ad69228e7fa813b558f51483028 (patch) | |
| tree | 540a22e54176aab483c3e142e4861de89867e18f | |
| parent | ae95f763dfb5e4fab3a9ff026b2f844c202625d7 (diff) | |
| download | pdfium-85ff9870a48e3ad69228e7fa813b558f51483028.tar.xz | |
Re-enable warning 4005 and remove _CRT_SECURE_NO_WARNINGS
The macro _CRT_SECURE_NO_WARNINGS is no longer needed for chromium
code as pdfium code itself is warning free;
For standalone build, the macro may suppress warnings from third
party code. But it has no use now as it is shadowed by disabled 4996
warnings.
This is one of the efforts to re-enable warnings for pdfium code.
BUG=pdfium:29
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1836443002 .
| -rw-r--r-- | BUILD.gn | 1 | ||||
| -rw-r--r-- | core/fxcrt/include/fx_system.h | 1 | ||||
| -rw-r--r-- | pdfium.gyp | 3 |
3 files changed, 1 insertions, 4 deletions
@@ -18,7 +18,6 @@ config("pdfium_config") { "PNG_PREFIX", "PNG_USE_READ_MACROS", "V8_DEPRECATION_WARNINGS", - "_CRT_SECURE_NO_WARNINGS", ] if (pdf_use_skia) { diff --git a/core/fxcrt/include/fx_system.h b/core/fxcrt/include/fx_system.h index 22fdef2014..4900634aa5 100644 --- a/core/fxcrt/include/fx_system.h +++ b/core/fxcrt/include/fx_system.h @@ -54,7 +54,6 @@ #endif #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_ -#define _CRT_SECURE_NO_WARNINGS #include <windows.h> #include <sal.h> #endif diff --git a/pdfium.gyp b/pdfium.gyp index e61237fafa..06f960b1d4 100644 --- a/pdfium.gyp +++ b/pdfium.gyp @@ -57,7 +57,6 @@ 'PNG_PREFIX', 'PNG_USE_READ_MACROS', 'V8_DEPRECATION_WARNINGS', - '_CRT_SECURE_NO_WARNINGS', ], 'include_dirs': [ # This is implicit in GN. @@ -94,7 +93,7 @@ }], ], 'msvs_disabled_warnings': [ - 4005, 4018, 4146, 4333, 4345, 4267, + 4018, 4146, 4333, 4345, 4267, ], 'variables': { 'clang_warning_flags': [ |