diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-11-21 16:45:21 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-11-21 16:45:21 +0000 |
| commit | 505644fae7b1ec405e0c278e84b5f8cab3d57a99 (patch) | |
| tree | aff77ab84ef5e0d51f70815402def370660f9c1f | |
| parent | 72d718ffb0bb5320c94ca387cb4938d946b076fc (diff) | |
| download | pdfium-505644fae7b1ec405e0c278e84b5f8cab3d57a99.tar.xz | |
Cleanup CXFA_BindItemsData methods
This CL removes the unused SetConnection method and makes the Get
methods const.
Change-Id: Id65cf41b07491a6503be0dec00db8b9ac73bb953
Reviewed-on: https://pdfium-review.googlesource.com/18912
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
| -rw-r--r-- | xfa/fxfa/parser/cxfa_binditemsdata.cpp | 11 | ||||
| -rw-r--r-- | xfa/fxfa/parser/cxfa_binditemsdata.h | 8 |
2 files changed, 6 insertions, 13 deletions
diff --git a/xfa/fxfa/parser/cxfa_binditemsdata.cpp b/xfa/fxfa/parser/cxfa_binditemsdata.cpp index 7640314f06..46ee0d5c15 100644 --- a/xfa/fxfa/parser/cxfa_binditemsdata.cpp +++ b/xfa/fxfa/parser/cxfa_binditemsdata.cpp @@ -11,19 +11,14 @@ CXFA_BindItemsData::CXFA_BindItemsData(CXFA_Node* pNode) : CXFA_DataData(pNode) {} -WideString CXFA_BindItemsData::GetLabelRef() { +WideString CXFA_BindItemsData::GetLabelRef() const { return m_pNode->JSNode()->GetCData(XFA_Attribute::LabelRef); } -WideString CXFA_BindItemsData::GetValueRef() { +WideString CXFA_BindItemsData::GetValueRef() const { return m_pNode->JSNode()->GetCData(XFA_Attribute::ValueRef); } -WideString CXFA_BindItemsData::GetRef() { +WideString CXFA_BindItemsData::GetRef() const { return m_pNode->JSNode()->GetCData(XFA_Attribute::Ref); } - -bool CXFA_BindItemsData::SetConnection(const WideString& wsConnection) { - return m_pNode->JSNode()->SetCData(XFA_Attribute::Connection, wsConnection, - false, false); -} diff --git a/xfa/fxfa/parser/cxfa_binditemsdata.h b/xfa/fxfa/parser/cxfa_binditemsdata.h index 4e59fa1657..ab4cac1836 100644 --- a/xfa/fxfa/parser/cxfa_binditemsdata.h +++ b/xfa/fxfa/parser/cxfa_binditemsdata.h @@ -16,11 +16,9 @@ class CXFA_BindItemsData : public CXFA_DataData { public: explicit CXFA_BindItemsData(CXFA_Node* pNode); - WideString GetLabelRef(); - WideString GetValueRef(); - WideString GetRef(); - - bool SetConnection(const WideString& wsConnection); + WideString GetLabelRef() const; + WideString GetValueRef() const; + WideString GetRef() const; }; #endif // XFA_FXFA_PARSER_CXFA_BINDITEMSDATA_H_ |