diff options
| author | tsepez <tsepez@chromium.org> | 2017-01-12 06:29:47 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2017-01-12 06:29:47 -0800 |
| commit | ffdfbb9ec274785e01dbdb64e9eef624fc1fb2e4 (patch) | |
| tree | 474ffa85ff36c02fcb764b8a3b13a7d00fb507e2 | |
| parent | e8b0281d1342cba6bb1d2f056e014df54b830459 (diff) | |
| download | pdfium-ffdfbb9ec274785e01dbdb64e9eef624fc1fb2e4.tar.xz | |
Remove unused CJS_Object::ExitInstance() method
All the work happens in the virtual dtors like it should.
Review-Url: https://codereview.chromium.org/2628843003
| -rw-r--r-- | fpdfsdk/javascript/JS_Define.h | 1 | ||||
| -rw-r--r-- | fpdfsdk/javascript/JS_Object.cpp | 3 | ||||
| -rw-r--r-- | fpdfsdk/javascript/JS_Object.h | 1 |
3 files changed, 0 insertions, 5 deletions
diff --git a/fpdfsdk/javascript/JS_Define.h b/fpdfsdk/javascript/JS_Define.h index 17dd8e9c70..feab4d1996 100644 --- a/fpdfsdk/javascript/JS_Define.h +++ b/fpdfsdk/javascript/JS_Define.h @@ -261,7 +261,6 @@ void JSMethod(const char* method_name_string, v8::Local<v8::Object> obj) { \ js_class_name* pObj = \ static_cast<js_class_name*>(pEngine->GetObjectPrivate(obj)); \ - pObj->ExitInstance(); \ delete pObj; \ } \ void js_class_name::DefineProps(CFXJS_Engine* pEngine) { \ diff --git a/fpdfsdk/javascript/JS_Object.cpp b/fpdfsdk/javascript/JS_Object.cpp index 88dd288f1e..9ef6cdd234 100644 --- a/fpdfsdk/javascript/JS_Object.cpp +++ b/fpdfsdk/javascript/JS_Object.cpp @@ -16,7 +16,6 @@ CJS_EmbedObj::~CJS_EmbedObj() { void FreeObject(const v8::WeakCallbackInfo<CJS_Object>& data) { CJS_Object* pJSObj = data.GetParameter(); - pJSObj->ExitInstance(); delete pJSObj; CFXJS_Engine::FreeObjectPrivate(data.GetInternalField(0)); } @@ -44,5 +43,3 @@ void CJS_Object::Dispose() { } void CJS_Object::InitInstance(IJS_Runtime* pIRuntime) {} - -void CJS_Object::ExitInstance() {} diff --git a/fpdfsdk/javascript/JS_Object.h b/fpdfsdk/javascript/JS_Object.h index c6491e27a0..658a5e212f 100644 --- a/fpdfsdk/javascript/JS_Object.h +++ b/fpdfsdk/javascript/JS_Object.h @@ -38,7 +38,6 @@ class CJS_Object { void Dispose(); virtual void InitInstance(IJS_Runtime* pIRuntime); - virtual void ExitInstance(); v8::Local<v8::Object> ToV8Object() { return m_pV8Object.Get(m_pIsolate); } |