diff options
| author | Ryan Harrison <rharrison@chromium.org> | 2017-08-02 16:57:56 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-08-02 21:23:30 +0000 |
| commit | 30152572648cff28747aec081090a59caafb1383 (patch) | |
| tree | dbb14a6197ee820048814c34d2ea9c4c7a3f1956 | |
| parent | 17b1c191da26e477c6898a8b06f2ff624f9e4c6b (diff) | |
| download | pdfium-30152572648cff28747aec081090a59caafb1383.tar.xz | |
Remove unused FromUnicode method
A helper method for FromUnicode existed that converted wchar_t* to
CFX_WideString before calling the remaining FromUnicode. This method
is not used in the code base, so it has been removed. This simplifies
converting FX_STRSIZE to be unsigned, since one of parameters to this
method was of type FX_STRSIZE.
BUG=pdfium:828
Change-Id: I3da677b84ac3b82ba48497e26d2ac80dd14302e6
Reviewed-on: https://pdfium-review.googlesource.com/9910
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
| -rw-r--r-- | core/fxcrt/cfx_bytestring.cpp | 6 | ||||
| -rw-r--r-- | core/fxcrt/cfx_bytestring.h | 1 |
2 files changed, 0 insertions, 7 deletions
diff --git a/core/fxcrt/cfx_bytestring.cpp b/core/fxcrt/cfx_bytestring.cpp index 77e0ecd610..f6634fc51d 100644 --- a/core/fxcrt/cfx_bytestring.cpp +++ b/core/fxcrt/cfx_bytestring.cpp @@ -710,12 +710,6 @@ CFX_WideString CFX_ByteString::UTF8Decode() const { } // static -CFX_ByteString CFX_ByteString::FromUnicode(const wchar_t* str, FX_STRSIZE len) { - FX_STRSIZE str_len = len >= 0 ? len : FXSYS_wcslen(str); - return FromUnicode(CFX_WideString(str, str_len)); -} - -// static CFX_ByteString CFX_ByteString::FromUnicode(const CFX_WideString& str) { return GetByteString(0, str.AsStringC()); } diff --git a/core/fxcrt/cfx_bytestring.h b/core/fxcrt/cfx_bytestring.h index 902d28f300..3f96c2f2f6 100644 --- a/core/fxcrt/cfx_bytestring.h +++ b/core/fxcrt/cfx_bytestring.h @@ -52,7 +52,6 @@ class CFX_ByteString { void clear() { m_pData.Reset(); } - static CFX_ByteString FromUnicode(const wchar_t* ptr, FX_STRSIZE len = -1); static CFX_ByteString FromUnicode(const CFX_WideString& str); // Explicit conversion to C-style string. |