Fix memory leaks in EmbedderTest::OpenDocument().

EmbedderTest::OpenDocument() does not gracefully handle the case of
being called twice in a given test case. So avoid doing that.

Review-Url: https://codereview.chromium.org/2088093002

2 files changed, 5 insertions, 1 deletions

diff --git a/core/fpdfapi/fpdf_parser/cpdf_parser_embeddertest.cpp b/core/fpdfapi/fpdf_parser/cpdf_parser_embeddertest.cpp
index 66b29a91c4..f523d6b31b 100644
--- a/core/fpdfapi/fpdf_parser/cpdf_parser_embeddertest.cpp
+++ b/core/fpdfapi/fpdf_parser/cpdf_parser_embeddertest.cpp
@@ -35,8 +35,11 @@ TEST_F(CPDFParserEmbeddertest, Feature_Linearized_Loading) {
   EXPECT_TRUE(OpenDocument("feature_linearized_loading.pdf", nullptr, true));
 }
 
-TEST_F(CPDFParserEmbeddertest, Bug_325) {
+TEST_F(CPDFParserEmbeddertest, Bug_325a) {
   EXPECT_FALSE(OpenDocument("bug_325_a.pdf"));
+}
+
+TEST_F(CPDFParserEmbeddertest, Bug_325b) {
   EXPECT_FALSE(OpenDocument("bug_325_b.pdf"));
 }
 
diff --git a/testing/embedder_test.cpp b/testing/embedder_test.cpp
index 59190a7751..9ef1e06dca 100644
--- a/testing/embedder_test.cpp
+++ b/testing/embedder_test.cpp
@@ -120,6 +120,7 @@ bool EmbedderTest::OpenDocument(const std::string& filename,
   if (!file_contents_)
     return false;
 
+  EXPECT_TRUE(!loader_);
   loader_ = new TestLoader(file_contents_.get(), file_length_);
   file_access_.m_FileLen = static_cast<unsigned long>(file_length_);
   file_access_.m_GetBlock = TestLoader::GetBlock;