summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRyan Harrison <rharrison@chromium.org>2018-06-01 15:49:03 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-06-01 15:49:03 +0000
commit1c2eea295db24fdebcfb9de4d3d6f0e8a02adee4 (patch)
tree8d983877b9e2782864c8a35d24502655d4315426
parent44b29d13bffa30733ca0e780c71ca867a3e9a033 (diff)
downloadpdfium-1c2eea295db24fdebcfb9de4d3d6f0e8a02adee4.tar.xz
Remove unused variable pDst from CFWL_Edit::OnValidate
GetOuter is const, so the assignment has no side effects, and the value is never user in the method body. Issue found with Clang Static Analyzer. Change-Id: I0116726a3df38dbf611db75ed03a0a17b4449d09 Reviewed-on: https://pdfium-review.googlesource.com/33531 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org>
-rw-r--r--xfa/fwl/cfwl_edit.cpp4
1 files changed, 0 insertions, 4 deletions
diff --git a/xfa/fwl/cfwl_edit.cpp b/xfa/fwl/cfwl_edit.cpp
index 7c4f0e1607..623cf4e956 100644
--- a/xfa/fwl/cfwl_edit.cpp
+++ b/xfa/fwl/cfwl_edit.cpp
@@ -327,10 +327,6 @@ void CFWL_Edit::OnSelChanged() {
}
bool CFWL_Edit::OnValidate(const WideString& wsText) {
- CFWL_Widget* pDst = GetOuter();
- if (!pDst)
- pDst = this;
-
CFWL_EventValidate event(this);
event.wsInsert = wsText;
event.bValidate = true;