diff options
| author | Ryan Harrison <rharrison@chromium.org> | 2018-04-25 21:52:04 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-04-25 21:52:04 +0000 |
| commit | 36a8c861ea7a77ceb018ea4a494ae497d39437e5 (patch) | |
| tree | caf4b143b460df12fab155edb6de10e92ea79a2f | |
| parent | 2456bbcbf51ed82ae9ce2836619bbebc5b926976 (diff) | |
| download | pdfium-36a8c861ea7a77ceb018ea4a494ae497d39437e5.tar.xz | |
Use local for return value in factory method
Follow requested in review after submit.
BUG=chromium:835608
Change-Id: I958a35f1cdaadbdb21e7c86b8c5b297ef01a2503
Reviewed-on: https://pdfium-review.googlesource.com/31316
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
| -rw-r--r-- | xfa/fxfa/cxfa_ffapp.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/xfa/fxfa/cxfa_ffapp.cpp b/xfa/fxfa/cxfa_ffapp.cpp index 67a7270824..a2b0c005f0 100644 --- a/xfa/fxfa/cxfa_ffapp.cpp +++ b/xfa/fxfa/cxfa_ffapp.cpp @@ -53,9 +53,9 @@ CFGAS_FontMgr* CXFA_FFApp::GetFDEFontMgr() { CXFA_FWLTheme* CXFA_FFApp::GetFWLTheme() { if (!m_pFWLTheme) { - m_pFWLTheme = pdfium::MakeUnique<CXFA_FWLTheme>(this); - if (!m_pFWLTheme->LoadCalendarFont()) - m_pFWLTheme = nullptr; + auto fwl_theme = pdfium::MakeUnique<CXFA_FWLTheme>(this); + if (fwl_theme->LoadCalendarFont()) + m_pFWLTheme = std::move(fwl_theme); } return m_pFWLTheme.get(); } |