summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2018-10-15 22:45:14 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-10-15 22:45:14 +0000
commit6735139528c4239d4a88c02004d2671c27418020 (patch)
tree311e3a80984aa4f31eb312a1f0d2b2e1e48584ae
parentd2e27d660a96080882e43825fb4b5d03e8a4d05a (diff)
downloadpdfium-6735139528c4239d4a88c02004d2671c27418020.tar.xz
Restrict fxcrt's visibility to third_party.
Change-Id: I4b4b1a8e78e2405791aca915e4d48a88e79444d5 Reviewed-on: https://pdfium-review.googlesource.com/c/43993 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org>
-rw-r--r--core/fxcrt/BUILD.gn7
-rw-r--r--third_party/BUILD.gn4
2 files changed, 10 insertions, 1 deletions
diff --git a/core/fxcrt/BUILD.gn b/core/fxcrt/BUILD.gn
index 170d4d045d..3a3852069e 100644
--- a/core/fxcrt/BUILD.gn
+++ b/core/fxcrt/BUILD.gn
@@ -89,7 +89,10 @@ jumbo_source_set("fxcrt") {
"../../fpdfsdk/*",
"../../fxbarcode:*",
"../../fxjs:*",
- "../../third_party:*",
+ "../../third_party:fx_agg",
+ "../../third_party:fx_lcms2",
+ "../../third_party:fx_tiff",
+ "../../third_party:pdfium_base",
"../../xfa/*",
]
deps = [
@@ -100,6 +103,8 @@ jumbo_source_set("fxcrt") {
"../../third_party:pdfium_base",
"//third_party/icu:icuuc",
]
+ allow_circular_includes_from = [ "../../third_party:pdfium_base" ]
+
if (is_posix || is_fuchsia) {
sources += [
"cfx_fileaccess_posix.cpp",
diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn
index a9a59ceebd..7a5a6c3c59 100644
--- a/third_party/BUILD.gn
+++ b/third_party/BUILD.gn
@@ -287,6 +287,9 @@ source_set("fx_lcms2") {
"lcms/src/cmswtpnt.c",
"lcms/src/cmsxform.c",
]
+ deps = [
+ "../core/fxcrt",
+ ]
}
if (!build_with_chromium) {
@@ -494,6 +497,7 @@ if (pdf_enable_xfa_tiff) {
}
deps = [
":zlib",
+ "../core/fxcrt",
"//third_party:jpeg",
]
sources = [