diff options
| author | Bruce Dawson <brucedawson@google.com> | 2014-11-17 15:22:03 -0800 |
|---|---|---|
| committer | Bruce Dawson <brucedawson@google.com> | 2014-11-17 15:22:03 -0800 |
| commit | 9ae02acf2f33fc68a6f3c00c3ad86e15725b8941 (patch) | |
| tree | 9573c098eb605a2d2a2ca967322b01f0c7adea0e | |
| parent | 418f6d0ddd5a1d3e93ebebd34cc42c3134b1bb84 (diff) | |
| download | pdfium-9ae02acf2f33fc68a6f3c00c3ad86e15725b8941.tar.xz | |
Zero initialize ch to avoid possible bug - conditions are very subtle.
Whether ch and iRet are read without being initialized depends on complex
preconditions and cannot be determined by looking at these function.
Therefore it seems prudent to zero initialize them to avoid any risk.
BUG=427616
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/727083002
| -rw-r--r-- | core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp | 2 | ||||
| -rw-r--r-- | core/src/fxcrt/fx_xml_parser.cpp | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp index fd94b88983..4a34de1c16 100644 --- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp +++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp @@ -2084,7 +2084,7 @@ FX_INT32 CPDF_Creator::Continue(IFX_Pause *pPause) if (m_iStage < 0) { return m_iStage; } - FX_INT32 iRet; + FX_INT32 iRet = 0; while (m_iStage < 100) { if (m_iStage < 20) { iRet = WriteDoc_Stage1(pPause); diff --git a/core/src/fxcrt/fx_xml_parser.cpp b/core/src/fxcrt/fx_xml_parser.cpp index 3608a74a93..26c6540350 100644 --- a/core/src/fxcrt/fx_xml_parser.cpp +++ b/core/src/fxcrt/fx_xml_parser.cpp @@ -282,7 +282,7 @@ void CXML_Parser::GetAttrValue(CFX_WideString &value) return; } CFX_UTF8Decoder decoder; - FX_BYTE mark = 0, ch; + FX_BYTE mark = 0, ch = 0; do { while (m_dwIndex < m_dwBufferSize) { ch = m_pBuffer[m_dwIndex]; |