summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2015-01-27 12:30:19 -0800
committerTom Sepez <tsepez@chromium.org>2015-01-27 12:30:19 -0800
commit506e6dc4649803ab56ef60d73d9a896f1876a7e6 (patch)
tree06a1eb55548cf86cc536608e46523de231835016
parenteef005055d6aafc2cc6066af37ce47d8b15ec7cd (diff)
downloadpdfium-506e6dc4649803ab56ef60d73d9a896f1876a7e6.tar.xz
Add embedder test for stream length beyond end of file.
This was fixed by https://codereview.chromium.org/743263002, but the bug remained open due to confusion. BUG=https://code.google.com/p/pdfium/issues/detail?id=57 R=thestig@chromium.org Review URL: https://codereview.chromium.org/878523003
-rw-r--r--BUILD.gn1
-rw-r--r--fpdfsdk/src/fpdftext_embeddertest.cpp23
-rw-r--r--pdfium.gyp1
-rw-r--r--testing/resources/bug_57.in48
-rw-r--r--testing/resources/bug_57.pdf57
5 files changed, 130 insertions, 0 deletions
diff --git a/BUILD.gn b/BUILD.gn
index a6ea102294..efabf9f9e2 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -815,6 +815,7 @@ test("pdfium_embeddertests") {
sources = [
"fpdfsdk/src/fpdf_dataavail_embeddertest.cpp",
"fpdfsdk/src/fpdfdoc_embeddertest.cpp",
+ "fpdfsdk/src/fpdftext_embeddertest.cpp",
"fpdfsdk/src/fpdfview_embeddertest.cpp",
"testing/embedder_test.cpp",
"testing/embedder_test.h",
diff --git a/fpdfsdk/src/fpdftext_embeddertest.cpp b/fpdfsdk/src/fpdftext_embeddertest.cpp
new file mode 100644
index 0000000000..3198fe0f86
--- /dev/null
+++ b/fpdfsdk/src/fpdftext_embeddertest.cpp
@@ -0,0 +1,23 @@
+// Copyright 2015 PDFium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "../../testing/embedder_test.h"
+#include "../../fpdfsdk/include/fpdfview.h"
+#include "../../fpdfsdk/include/fpdftext.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class FPDFTextEmbeddertest : public EmbedderTest {
+};
+
+// Test that the page has characters despite a bad stream length.
+TEST_F(FPDFTextEmbeddertest, StreamLengthPastEndOfFile) {
+ EXPECT_TRUE(OpenDocument("testing/resources/bug_57.pdf"));
+ FPDF_FORMHANDLE form_handle = SetFormFillEnvironment();
+ FPDF_PAGE page = LoadPage(0, form_handle);
+ EXPECT_NE(nullptr, page);
+ FPDF_TEXTPAGE textpage = FPDFText_LoadPage(page);
+ EXPECT_NE(nullptr, textpage);
+ EXPECT_EQ(13, FPDFText_CountChars(textpage));
+ ClearFormFillEnvironment(form_handle);
+}
diff --git a/pdfium.gyp b/pdfium.gyp
index eedbe5da37..cbdf4b70ac 100644
--- a/pdfium.gyp
+++ b/pdfium.gyp
@@ -840,6 +840,7 @@
'sources': [
'fpdfsdk/src/fpdf_dataavail_embeddertest.cpp',
'fpdfsdk/src/fpdfdoc_embeddertest.cpp',
+ 'fpdfsdk/src/fpdftext_embeddertest.cpp',
'fpdfsdk/src/fpdfview_embeddertest.cpp',
'testing/embedder_test.cpp',
'testing/embedder_test.h',
diff --git a/testing/resources/bug_57.in b/testing/resources/bug_57.in
new file mode 100644
index 0000000000..0825efdfa8
--- /dev/null
+++ b/testing/resources/bug_57.in
@@ -0,0 +1,48 @@
+{{header}}
+{{object 1 0}} <<
+ /Type /Catalog
+ /Pages 2 0 R
+>>
+{{object 2 0}} <<
+ /Type /Pages
+ /MediaBox [ 0 0 200 200 ]
+ /Count 1
+ /Kids [ 3 0 R ]
+>>
+endobj
+{{object 3 0}} <<
+ /Type /Page
+ /Parent 2 0 R
+ /Resources <<
+ /Font <<
+ /F1 4 0 R
+ >>
+ >>
+ /Contents 5 0 R
+>>
+endobj
+{{object 4 0}} <<
+ /Type /Font
+ /Subtype /Type1
+ /BaseFont /Times-Roman
+>>
+endobj
+% page content with streamlength past end-of-file.
+{{object 5 0}} <<
+ /Length 9999
+>>
+stream
+BT
+70 50 TD
+/F1 12 Tf
+(Hello, world!) Tj
+ET
+endstream
+endobj
+{{xref}}
+trailer <<
+ /Size 6
+ /Root 1 0 R
+>>
+{{startxref}}
+%%EOF
diff --git a/testing/resources/bug_57.pdf b/testing/resources/bug_57.pdf
new file mode 100644
index 0000000000..d954c43f54
--- /dev/null
+++ b/testing/resources/bug_57.pdf
@@ -0,0 +1,57 @@
+%PDF-1.7
+% ò¤ô
+1 0 obj <<
+ /Type /Catalog
+ /Pages 2 0 R
+>>
+2 0 obj <<
+ /Type /Pages
+ /MediaBox [ 0 0 200 200 ]
+ /Count 1
+ /Kids [ 3 0 R ]
+>>
+endobj
+3 0 obj <<
+ /Type /Page
+ /Parent 2 0 R
+ /Resources <<
+ /Font <<
+ /F1 4 0 R
+ >>
+ >>
+ /Contents 5 0 R
+>>
+endobj
+4 0 obj <<
+ /Type /Font
+ /Subtype /Type1
+ /BaseFont /Times-Roman
+>>
+endobj
+% page content with streamlength past end-of-file.
+5 0 obj <<
+ /Length 9999
+>>
+stream
+BT
+70 50 TD
+/F1 12 Tf
+(Hello, world!) Tj
+ET
+endstream
+endobj
+xref
+0 6
+0000000000 65536 f
+0000000015 00000 n
+0000000061 00000 n
+0000000154 00000 n
+0000000280 00000 n
+0000000409 00000 n
+trailer <<
+ /Size 6
+ /Root 1 0 R
+>>
+startxref
+506
+%%EOF