diff options
| author | Jun Fang <jun_fang@foxitsoftware.com> | 2016-01-11 19:08:21 -0800 |
|---|---|---|
| committer | Jun Fang <jun_fang@foxitsoftware.com> | 2016-01-11 19:08:21 -0800 |
| commit | f3c9cf66d6a850b8225bc161722bed8aed440a2f (patch) | |
| tree | bc3789329155da2eca26809f61ffe30d6c7f394c | |
| parent | 65ac873de9164c01af2579a773344c4bca7254d7 (diff) | |
| download | pdfium-f3c9cf66d6a850b8225bc161722bed8aed440a2f.tar.xz | |
XFA: Fix memory leakage on Linux
BUG=pdfium:348
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1579503002 .
| -rw-r--r-- | fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp | 1 | ||||
| -rw-r--r-- | xfa/src/fgas/include/fx_utl.h | 1 | ||||
| -rw-r--r-- | xfa/src/fgas/src/crt/fx_utils.cpp | 4 | ||||
| -rw-r--r-- | xfa/src/fxfa/src/app/xfa_ffapp.cpp | 1 |
4 files changed, 7 insertions, 0 deletions
diff --git a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp index d623a68637..92d16b64e2 100644 --- a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp +++ b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp @@ -65,6 +65,7 @@ CPDFXFA_Document::~CPDFXFA_Document() { CloseXFADoc(pDocHandler);
}
}
+ delete m_pXFADoc;
}
}
diff --git a/xfa/src/fgas/include/fx_utl.h b/xfa/src/fgas/include/fx_utl.h index c58d5a1be6..f65aa994ea 100644 --- a/xfa/src/fgas/include/fx_utl.h +++ b/xfa/src/fgas/include/fx_utl.h @@ -46,6 +46,7 @@ class CFX_ThreadLock { class CFX_BaseArray : public CFX_Target {
protected:
CFX_BaseArray(int32_t iGrowSize, int32_t iBlockSize);
+ ~CFX_BaseArray();
int32_t GetSize() const;
int32_t GetBlockSize() const;
uint8_t* AddSpaceTo(int32_t index);
diff --git a/xfa/src/fgas/src/crt/fx_utils.cpp b/xfa/src/fgas/src/crt/fx_utils.cpp index 7cc4de7022..e8be0d8d5f 100644 --- a/xfa/src/fgas/src/crt/fx_utils.cpp +++ b/xfa/src/fgas/src/crt/fx_utils.cpp @@ -36,6 +36,10 @@ CFX_BaseArray::CFX_BaseArray(int32_t iGrowSize, int32_t iBlockSize) { FXSYS_assert(iGrowSize > 0 && iBlockSize > 0);
m_pData = new FX_BASEARRAYDATA(iGrowSize, iBlockSize);
}
+CFX_BaseArray::~CFX_BaseArray() {
+ RemoveAll();
+ delete m_pData;
+}
int32_t CFX_BaseArray::GetSize() const {
return m_pData->iBlockCount;
}
diff --git a/xfa/src/fxfa/src/app/xfa_ffapp.cpp b/xfa/src/fxfa/src/app/xfa_ffapp.cpp index fb37fb7ba3..8fb614b8a3 100644 --- a/xfa/src/fxfa/src/app/xfa_ffapp.cpp +++ b/xfa/src/fxfa/src/app/xfa_ffapp.cpp @@ -92,6 +92,7 @@ CXFA_FFApp::~CXFA_FFApp() { if (m_pFWLApp) {
m_pFWLApp->Finalize();
m_pFWLApp->Release();
+ delete m_pFWLApp;
}
if (m_pFWLTheme) {
m_pFWLTheme->Release();
|