diff options
| author | Tom Sepez <tsepez@chromium.org> | 2016-03-08 08:42:37 -0800 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2016-03-08 08:42:37 -0800 |
| commit | 31d7a189bcbc703602da3352248616625087ef40 (patch) | |
| tree | ba49c2fe98600d9f49e11fe3e47c8908093721fd | |
| parent | fffc96359b48ca4ac873dc4a109788750ad87899 (diff) | |
| download | pdfium-31d7a189bcbc703602da3352248616625087ef40.tar.xz | |
CXFA_TextParseContext::m_eDisplay is too small
enum FDE_CSSDISPLAY contains about 20 values, which won't fit into
4 bits. Avoid packing and burn the memory, since I worry about the
m_dwMatchedDelcs geting truncated, too.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1771193002 .
| -rw-r--r-- | xfa/src/fxfa/src/app/xfa_textlayout.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xfa/src/fxfa/src/app/xfa_textlayout.h b/xfa/src/fxfa/src/app/xfa_textlayout.h index 03067ced5a..d096a645a7 100644 --- a/xfa/src/fxfa/src/app/xfa_textlayout.h +++ b/xfa/src/fxfa/src/app/xfa_textlayout.h @@ -79,8 +79,8 @@ class CXFA_TextParseContext : public CFX_Target { protected: IFDE_CSSDeclaration** m_ppMatchedDecls; - FX_DWORD m_dwMatchedDecls : 28; - FDE_CSSDISPLAY m_eDisplay : 4; + FX_DWORD m_dwMatchedDecls; + FDE_CSSDISPLAY m_eDisplay; }; class CXFA_TextParser { |