diff options
| author | Tom Sepez <tsepez@chromium.org> | 2017-02-13 12:01:40 -0800 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-02-13 21:01:03 +0000 |
| commit | 9e41d0461d175410f6ea7573e729dc1ae14e846d (patch) | |
| tree | 021be32f4c6d4de3ea76853497fea00a78f6b852 | |
| parent | da83d3a5cc09c4056310b3cf299dbbccd5c70d11 (diff) | |
| download | pdfium-9e41d0461d175410f6ea7573e729dc1ae14e846d.tar.xz | |
Use container with stable iterator for m_Icons.
The container may grow while it is being traversed in JS.
BUG=691371
Change-Id: I73ee536458697267c69e6c3ada96e28546d11a4e
Reviewed-on: https://pdfium-review.googlesource.com/2690
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
| -rw-r--r-- | fpdfsdk/javascript/Document.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fpdfsdk/javascript/Document.h b/fpdfsdk/javascript/Document.h index 227c4284bb..7786c77881 100644 --- a/fpdfsdk/javascript/Document.h +++ b/fpdfsdk/javascript/Document.h @@ -288,7 +288,7 @@ class Document : public CJS_EmbedObj { CPDFSDK_FormFillEnvironment::ObservedPtr m_pFormFillEnv; CFX_WideString m_cwBaseURL; std::list<std::unique_ptr<CJS_DelayData>> m_DelayData; - std::vector<std::unique_ptr<IconElement>> m_Icons; + std::list<std::unique_ptr<IconElement>> m_Icons; // For iterator stability. bool m_bDelay; }; |