summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Sinclair <dsinclair@chromium.org>2018-05-25 15:57:04 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-05-25 15:57:04 +0000
commit0913752e0d218208aadc80690a39f523e5cc21cc (patch)
tree4f1bfb0d01422ef798dc83522cc5a57df3fe9cc5
parent08d9f6e3f0a68bae9eedb015458071e1481d28f4 (diff)
downloadpdfium-0913752e0d218208aadc80690a39f523e5cc21cc.tar.xz
[xfa] Rename pValue to pReturn for clarity
This CL renames the pValue parameters to the CJX_EventPseudoModel Property helpers. This makes it a little clearer that the thing we're setting is _not_ pValue but wsValue. Bug: 1066 Change-Id: I1f468659c4e241059da0bbe43c461be788cd62a0 Reviewed-on: https://pdfium-review.googlesource.com/32931 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
-rw-r--r--fxjs/xfa/cjx_eventpseudomodel.cpp19
1 files changed, 10 insertions, 9 deletions
diff --git a/fxjs/xfa/cjx_eventpseudomodel.cpp b/fxjs/xfa/cjx_eventpseudomodel.cpp
index db5c14ac14..e652acb3e2 100644
--- a/fxjs/xfa/cjx_eventpseudomodel.cpp
+++ b/fxjs/xfa/cjx_eventpseudomodel.cpp
@@ -17,28 +17,29 @@
namespace {
-void StringProperty(CFXJSE_Value* pValue, WideString* wsValue, bool bSetting) {
+void StringProperty(CFXJSE_Value* pReturn, WideString* wsValue, bool bSetting) {
if (bSetting) {
- *wsValue = pValue->ToWideString();
+ *wsValue = pReturn->ToWideString();
return;
}
- pValue->SetString(wsValue->UTF8Encode().AsStringView());
+
+ pReturn->SetString(wsValue->UTF8Encode().AsStringView());
}
-void InterProperty(CFXJSE_Value* pValue, int32_t* iValue, bool bSetting) {
+void InterProperty(CFXJSE_Value* pReturn, int32_t* iValue, bool bSetting) {
if (bSetting) {
- *iValue = pValue->ToInteger();
+ *iValue = pReturn->ToInteger();
return;
}
- pValue->SetInteger(*iValue);
+ pReturn->SetInteger(*iValue);
}
-void BooleanProperty(CFXJSE_Value* pValue, bool* bValue, bool bSetting) {
+void BooleanProperty(CFXJSE_Value* pReturn, bool* bValue, bool bSetting) {
if (bSetting) {
- *bValue = pValue->ToBoolean();
+ *bValue = pReturn->ToBoolean();
return;
}
- pValue->SetBoolean(*bValue);
+ pReturn->SetBoolean(*bValue);
}
} // namespace