summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRyan Harrison <rharrison@chromium.org>2018-07-04 15:35:58 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-07-04 15:35:58 +0000
commitd774a73b59ac36d533064041196d051c032eee6b (patch)
tree51a0cae83a0eef8fa20c35162217aabd12c8bcf2
parent94f7b75b4d5d1988e599ed4a9a7b6cf451994f1d (diff)
downloadpdfium-d774a73b59ac36d533064041196d051c032eee6b.tar.xz
Remove gn arg 'use_coverage'chromium/3482
This flag was used for enabling GCOV style coverage data generation. Our code coverage tools now use the native LLVM tools, so no longer depend on this flag. Having this flag is confusing and a source of developer error. Change-Id: I42cfce6fe9e5a7d0f0ac13abdb5fec90f61f1c13 Reviewed-on: https://pdfium-review.googlesource.com/37130 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org>
-rw-r--r--BUILD.gn9
-rw-r--r--pdfium.gni3
-rw-r--r--samples/BUILD.gn9
3 files changed, 0 insertions, 21 deletions
diff --git a/BUILD.gn b/BUILD.gn
index fb251fc9e4..d30640f30c 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -62,15 +62,6 @@ config("pdfium_common_config") {
defines += [ "PDFIUM_PRINT_TEXT_WITH_GDI" ]
}
- if (use_coverage && is_clang) {
- cflags += [
- "--coverage",
- "-g",
- "-O0",
- ]
- ldflags += [ "--coverage" ]
- }
-
if (is_win) {
# Assume UTF-8 by default to avoid code page dependencies.
cflags += [ "/utf-8" ]
diff --git a/pdfium.gni b/pdfium.gni
index 2b34cbc89d..f451c84829 100644
--- a/pdfium.gni
+++ b/pdfium.gni
@@ -56,9 +56,6 @@ declare_args() {
# Enable callgrind for performance profiling
enable_callgrind = false
- # Enable coverage information
- use_coverage = false
-
# Don't build against bundled zlib.
use_system_zlib = false
diff --git a/samples/BUILD.gn b/samples/BUILD.gn
index 3274338d49..30cc8ef6e9 100644
--- a/samples/BUILD.gn
+++ b/samples/BUILD.gn
@@ -36,15 +36,6 @@ config("pdfium_samples_config") {
if (enable_callgrind) {
defines += [ "ENABLE_CALLGRIND" ]
}
-
- if (use_coverage && is_clang) {
- cflags += [
- "--coverage",
- "-g",
- "-O0",
- ]
- ldflags += [ "--coverage" ]
- }
}
executable("pdfium_test") {