summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-07-23 20:55:04 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-07-23 20:55:04 +0000
commit1116ef0b1c45a4968d45a21d995193a7670126b3 (patch)
tree6653d12dacae0cb6557eb6acbea41d1c607506a1
parent4c358488d0a8daf3a625cae842efcf27a3bb62f5 (diff)
downloadpdfium-1116ef0b1c45a4968d45a21d995193a7670126b3.tar.xz
Remove unused CFXJSE_Arguments::GetObject()chromium/3501
Insert another unowned ptr along the way. Change-Id: I953baa3448282fd4f655bb99524f131f66b7ed86 Reviewed-on: https://pdfium-review.googlesource.com/38593 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
-rw-r--r--fxjs/cfxjse_arguments.cpp9
-rw-r--r--fxjs/cfxjse_arguments.h4
2 files changed, 1 insertions, 12 deletions
diff --git a/fxjs/cfxjse_arguments.cpp b/fxjs/cfxjse_arguments.cpp
index 663996ce88..b8670ad981 100644
--- a/fxjs/cfxjse_arguments.cpp
+++ b/fxjs/cfxjse_arguments.cpp
@@ -45,15 +45,6 @@ ByteString CFXJSE_Arguments::GetUTF8String(int32_t index) const {
return ByteString(*szStringVal);
}
-CFXJSE_HostObject* CFXJSE_Arguments::GetObject(int32_t index,
- CFXJSE_Class* pClass) const {
- v8::Local<v8::Value> hValue = (*m_pInfo)[index];
- ASSERT(!hValue.IsEmpty());
- if (!hValue->IsObject())
- return nullptr;
- return FXJSE_RetrieveObjectBinding(hValue.As<v8::Object>(), pClass);
-}
-
CFXJSE_Value* CFXJSE_Arguments::GetReturnValue() const {
return m_pRetValue.Get();
}
diff --git a/fxjs/cfxjse_arguments.h b/fxjs/cfxjse_arguments.h
index 92a36c842e..e24fc8feb8 100644
--- a/fxjs/cfxjse_arguments.h
+++ b/fxjs/cfxjse_arguments.h
@@ -25,12 +25,10 @@ class CFXJSE_Arguments {
int32_t GetInt32(int32_t index) const;
float GetFloat(int32_t index) const;
ByteString GetUTF8String(int32_t index) const;
- CFXJSE_HostObject* GetObject(int32_t index,
- CFXJSE_Class* pClass = nullptr) const;
CFXJSE_Value* GetReturnValue() const;
private:
- const v8::FunctionCallbackInfo<v8::Value>* m_pInfo;
+ UnownedPtr<const v8::FunctionCallbackInfo<v8::Value>> m_pInfo;
UnownedPtr<CFXJSE_Value> m_pRetValue;
};