diff options
author | Brett Wilson <brettw@chromium.org> | 2015-08-31 13:45:07 -0700 |
---|---|---|
committer | Brett Wilson <brettw@chromium.org> | 2015-08-31 13:45:07 -0700 |
commit | 7858c0aae5ee449dafe23c0e1aa0c164ae2889eb (patch) | |
tree | 357d8600ac11bac2e17941c0ee1a0855f3646252 /BUILD.gn | |
parent | 0c9f1d8f6dd6bb8b9c3eba73e4ffd0bb2ca4fd97 (diff) | |
download | pdfium-7858c0aae5ee449dafe23c0e1aa0c164ae2889eb.tar.xz |
Move configs out of targets in GN build files.chromium/2500chromium/2499chromium/2498
I'm trying to disallow this since it's confusing. It looks like it provides
scoping for the inner config, but it is actually no different than declaring
the config at the top level. For clarify, all configs and targets should be
declared at the top level.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/1328443003 .
Diffstat (limited to 'BUILD.gn')
-rw-r--r-- | BUILD.gn | 17 |
1 files changed, 9 insertions, 8 deletions
@@ -393,6 +393,15 @@ static_library("fxcodec") { ] } +config("fxge_warnings") { + if (is_clang) { + cflags = [ + # http://code.google.com/p/pdfium/issues/detail?id=188 + "-Wno-switch", + ] + } +} + static_library("fxcrt") { sources = [ "core/include/fxcrt/fx_basic.h", @@ -504,14 +513,6 @@ static_library("fxge") { "core/src/fxge/ge/text_int.h", ] - config("fxge_warnings") { - if (is_clang) { - cflags = [ - # http://code.google.com/p/pdfium/issues/detail?id=188 - "-Wno-switch", - ] - } - } configs -= [ "//build/config/compiler:chromium_code" ] configs += [ ":pdfium_config", |