Re-enable all the windows warnings except 4267

The code is changed or had been changed to no longer generate these
warnings. It is safe to re-enabled these warnings.

In this code change, we fixed some code which generates warnings 4018
(signed/unsigned mismatch) and 4146 (unary minus operator applied to
unsigned type, result still unsigned).

Warning 4333 (right shift by too large amount, data loss) and 4345
(an object of POD type constructed with an initializer of the form ()
will be default-initialized) are no longer generated.

The same setting is applied and verified for GN build as well.

BUG=pdfium:29

Review URL: https://codereview.chromium.org/1849443003

1 files changed, 0 insertions, 17 deletions

diff --git a/BUILD.gn b/BUILD.gn
index b0ab4e1940..ad12068ad3 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -43,24 +43,7 @@ config("pdfium_config") {
 
   if (is_win) {
     cflags += [
-      "/wd4005",
-      "/wd4018",
-      "/wd4146",
-      "/wd4333",
-      "/wd4345",
       "/wd4267",
-
-      # TODO(ochang): Investigate if this can be fixed properly.
-      "/wd4201",
-
-      # TODO(thestig): Fix all instances, remove this, pdfium:29
-      "/wd4245",
-      "/wd4310",
-      "/wd4389",
-      "/wd4701",
-      "/wd4702",
-      "/wd4706",
-      "/wd4800",
     ]
   }