Workaround dubious casting between CXFA_Object and void* in FXJSE

This is just a crock to get things working until we fix the
underlying issue.

When there's single-inheritance, it may often work in practice
to C-style (reinterpret) cast a Derived* ptr to void* and then
back to a Base* ptr.  One place where this blows up is if
Derived has virtual functions but Base does not, in which case
the world will be offset by the size of a vtable ptr.

Because of the use of void* types in FXJSE, the above was happening
when setting a CXFA_ThisProxy (Derived, virtual) to be a global
object (void*). This would then be cast back to a CFXA_Object
(Base, non-virtual) and chaos is ensured.

Not sure how far back this goes.

Along the way, pick up some tidying which was necessary for
simplicity while tracking this down.

BUG=613607

Review-Url: https://codereview.chromium.org/2015143005

1 files changed, 0 insertions, 1 deletions

diff --git a/BUILD.gn b/BUILD.gn
index 1550209ce1..580bc573d1 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -1578,7 +1578,6 @@ if (pdf_enable_xfa) {
         "xfa/fxjse/runtime.cpp",
         "xfa/fxjse/runtime.h",
         "xfa/fxjse/scope_inline.h",
-        "xfa/fxjse/util_inline.h",
         "xfa/fxjse/value.cpp",
         "xfa/fxjse/value.h",
       ]