diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-04-11 21:18:38 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-04-11 21:18:38 +0000 |
| commit | c763970de6e749123af76170c16bbc3929058437 (patch) | |
| tree | 6221c524b043f0f7986eeceac6a26fea6a843c4d /BUILD.gn | |
| parent | 1e934f6868465bca960f9f13489489ba1d649581 (diff) | |
| download | pdfium-c763970de6e749123af76170c16bbc3929058437.tar.xz | |
Fix issues with PDFium third_party/base/span.h
Remove stray const in operator[] that was introduced when downgrading
from C++14 to C++11 syntax.
Add missing Get() in first() that was introduced when converting
to UnownedPtr.
Prevent ASAN from flagging spans where the UnownedPtr points to byte
N+1 of a N byte object, and the span is empty. This is legal in C for
ordinary pointers so long as the pointer isn't de-referenced, but is
not allowed per the rules for UnownedPtr.
Change-Id: Ic143c5ef4e37c1cf86f0a3e5408be6e2076a85e2
Reviewed-on: https://pdfium-review.googlesource.com/30212
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'BUILD.gn')
| -rw-r--r-- | BUILD.gn | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -2905,6 +2905,7 @@ test("pdfium_unittests") { "core/fxcrt/fx_system_unittest.cpp", "core/fxcrt/maybe_owned_unittest.cpp", "core/fxcrt/observable_unittest.cpp", + "core/fxcrt/pdfium_span_unittest.cpp", "core/fxcrt/retain_ptr_unittest.cpp", "core/fxcrt/shared_copy_on_write_unittest.cpp", "core/fxcrt/string_pool_template_unittest.cpp", |