diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-09-26 16:39:20 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-09-27 15:48:38 +0000 |
| commit | c29c16f8cb98f4892dd13b0c7b6b08280687d6b0 (patch) | |
| tree | 351a719c5fc70a6b555ef21cc64ae7342f59c5ec /BUILD.gn | |
| parent | fe9ea0eff300458314d8a422d064597eb588e25d (diff) | |
| download | pdfium-c29c16f8cb98f4892dd13b0c7b6b08280687d6b0.tar.xz | |
Enable PRINTF_FORMAT for clang
This ports
https://chromium-review.googlesource.com/c/chromium/src/+/599127 from
Chromium to PDFium.
Because VC++ does not have format-string checking for user-defined
functions during normal compiles, because clang-cl had its format-string
checking disabled, because some files are only compiled on Windows, and
because VC++'s /analyze doesn't build all targets, and because VC++'s
format-string checking is more lenient than clang's... 50 warnings about
format-string mismatches crept in to Chromium's build. Seven of these
were somewhat serious, with four being wchar_t*/char* mismatches because
of base::FilePath and the other three being size_t/%d mismatches.
Now that all of the mismatches are corrected this change enables
PRINTF_FORMAT checking with clang-cl so that these bugs never return.
Bug: pdfium:909
Change-Id: I683592f5015b31b4dd04dfe81e6866389b544efe
Reviewed-on: https://pdfium-review.googlesource.com/14834
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'BUILD.gn')
0 files changed, 0 insertions, 0 deletions