diff options
author | Henrique Nakashima <hnakashima@chromium.org> | 2017-08-10 15:13:19 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2017-08-10 15:13:33 +0000 |
commit | 7e805d1a6f3bf7ddd04b2c1ce857a2cf6d9ff873 (patch) | |
tree | 0aab30fc879ea390d3f3351dafc5511e16ddedc0 /BUILD.gn | |
parent | e6c67cd64a80bd67c587ad3ffb380fe1b7574d1f (diff) | |
download | pdfium-7e805d1a6f3bf7ddd04b2c1ce857a2cf6d9ff873.tar.xz |
Revert "Add a build target and a proper export header for shared library builds."
This reverts commit 00334675c18a0203f313cceb670c970a77280f49.
Reason for revert: Breaking the deps roller - https://chromium-review.googlesource.com/c/609307
Original change's description:
> Add a build target and a proper export header for shared library builds.
>
> This CL adds support for Chromium's component build feature to pdfium.
>
> The export header stub in fpdfview.h is expanded to match Chromium's
> export mechanisms and patterns (fixes pdfium:825).
>
> A component/shared library build can be triggered by adding
>
> is_component_build = true
>
> as a gn argument. Please note that setting this will also affect some
> of pdfiums dependencies like v8, which will be build as components
> too.
>
> Additionally, this CL provides a "pdf_source_set" template which
> dynamically enables the use of "source_set" when building a complete
> static library or a shared library to reduce build time.
>
> When testing this it is recommended to only build the pdfium target as
> most of pdfiums test rely on non-public functions which aren't exported
> by the shared library.
>
> Bug: pdfium:825,pdfium:826
> Change-Id: Icedc538ec535e11d1e53c4d5fabc8c064b275752
> Reviewed-on: https://pdfium-review.googlesource.com/8970
> Reviewed-by: dsinclair <dsinclair@chromium.org>
> Commit-Queue: dsinclair <dsinclair@chromium.org>
TBR=thestig@chromium.org,tsepez@chromium.org,brucedawson@chromium.org,dsinclair@google.com,dsinclair@chromium.org,licorn@gmail.com
Change-Id: Ib02af2298932481293f50d362ae87bfedf284821
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: pdfium:825, pdfium:826
Reviewed-on: https://pdfium-review.googlesource.com/10550
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Diffstat (limited to 'BUILD.gn')
-rw-r--r-- | BUILD.gn | 27 |
1 files changed, 13 insertions, 14 deletions
@@ -19,7 +19,6 @@ config("pdfium_common_config") { ldflags = [] include_dirs = [ "." ] defines = [ - "FPDF_IMPLEMENTATION", "OPJ_STATIC", "PNG_PREFIX", "PNG_USE_READ_MACROS", @@ -100,7 +99,7 @@ config("xfa_warnings") { } } -component("pdfium") { +static_library("pdfium") { sources = [ "fpdfsdk/cba_annotiterator.cpp", "fpdfsdk/cba_annotiterator.h", @@ -229,7 +228,7 @@ component("pdfium") { } } -pdf_source_set("test_support") { +static_library("test_support") { testonly = true sources = [ "testing/fx_string_testhelpers.cpp", @@ -262,7 +261,7 @@ pdf_source_set("test_support") { configs += [ ":pdfium_core_config" ] } -pdf_source_set("image_diff") { +static_library("image_diff") { testonly = true sources = [ "testing/image_diff/image_diff_png.cpp", @@ -282,7 +281,7 @@ visibility = [ "//:gn_visibility", ] -pdf_source_set("fdrm") { +static_library("fdrm") { sources = [ "core/fdrm/crypto/fx_crypt.cpp", "core/fdrm/crypto/fx_crypt.h", @@ -295,7 +294,7 @@ pdf_source_set("fdrm") { ] } -pdf_source_set("fpdfdoc") { +static_library("fpdfdoc") { sources = [ "core/fpdfdoc/cline.cpp", "core/fpdfdoc/cline.h", @@ -795,7 +794,7 @@ config("fxge_warnings") { } } -pdf_source_set("fxcrt") { +static_library("fxcrt") { sources = [ "core/fxcrt/cfx_bytestring.cpp", "core/fxcrt/cfx_bytestring.h", @@ -1120,7 +1119,7 @@ static_library("fxge") { } } -pdf_source_set("pwl") { +static_library("pwl") { sources = [ "fpdfsdk/pwl/cpwl_appstream.cpp", "fpdfsdk/pwl/cpwl_appstream.h", @@ -1161,7 +1160,7 @@ pdf_source_set("pwl") { ] } -pdf_source_set("javascript") { +static_library("javascript") { sources = [ "fpdfsdk/javascript/ijs_event_context.h", "fpdfsdk/javascript/ijs_runtime.h", @@ -1224,7 +1223,7 @@ pdf_source_set("javascript") { } } -pdf_source_set("formfiller") { +static_library("formfiller") { sources = [ "fpdfsdk/formfiller/cba_fontmap.cpp", "fpdfsdk/formfiller/cba_fontmap.h", @@ -1256,7 +1255,7 @@ pdf_source_set("formfiller") { } if (pdf_enable_v8) { - pdf_source_set("fxjs") { + static_library("fxjs") { sources = [ "fxjs/fxjs_v8.cpp", "fxjs/fxjs_v8.h", @@ -1296,7 +1295,7 @@ if (pdf_enable_v8) { } if (pdf_enable_xfa) { - pdf_source_set("fpdfxfa") { + static_library("fpdfxfa") { sources = [ "fpdfsdk/fpdfxfa/cpdfxfa_context.cpp", "fpdfsdk/fpdfxfa/cpdfxfa_context.h", @@ -1315,7 +1314,7 @@ if (pdf_enable_xfa) { configs += [ ":pdfium_core_config" ] } - pdf_source_set("fxbarcode") { + static_library("fxbarcode") { sources = [ "fxbarcode/BC_Library.cpp", "fxbarcode/BC_Library.h", @@ -1450,7 +1449,7 @@ if (pdf_enable_xfa) { configs += [ ":pdfium_core_config" ] } - pdf_source_set("xfa") { + static_library("xfa") { sources = [ "xfa/fde/cfde_path.cpp", "xfa/fde/cfde_path.h", |