diff options
| author | tonikitoo <tonikitoo@igalia.com> | 2016-09-21 12:44:56 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-09-21 12:44:56 -0700 |
| commit | 81d92f8ffc5e632ade8c507b8f2e34c5fe3ca902 (patch) | |
| tree | 71748677afac42cfa22c3cf808701274a50274c4 /OWNERS | |
| parent | 37f6e2cbd5321fda5ad3000610371402eda3da65 (diff) | |
| download | pdfium-81d92f8ffc5e632ade8c507b8f2e34c5fe3ca902.tar.xz | |
Avoid static initializers and global variables in 'pdfium_test'.
This CL aims to follow up on thestig's past-land feedback
receveid on https://codereview.chromium.org/2277063003/#msg15 .
In order to avoid static initializers and global data
declaration, CL adds a data struct named PDFiumTest_FPDF_FORMFILLINFO,
which has FPDF_FORMFILLINFO as the first struct member definition.
This allows the use of reinterpret_cast to/from
PDFiumTest_FPDF_FORMFILLINFO and PDF_FORMFILLINFO.
PDFiumTest_FPDF_FORMFILLINFO also two more struct members,
'loadedPages' and 'formHandle', which were previously global
variables.
Review-Url: https://codereview.chromium.org/2330043002
Diffstat (limited to 'OWNERS')
0 files changed, 0 insertions, 0 deletions