summaryrefslogtreecommitdiff
path: root/build_gyp/standalone.gypi
diff options
context:
space:
mode:
authordsinclair <dsinclair@chromium.org>2016-04-26 11:05:26 -0700
committerCommit bot <commit-bot@chromium.org>2016-04-26 11:05:26 -0700
commit76c53794b6202ec37f6dcace5f2ae86870e953b6 (patch)
treeb7c9fce179cee0be2ac01ff966e6521169831e03 /build_gyp/standalone.gypi
parent186a78eb0a821a2f1feef524cb590d0fea2009ba (diff)
downloadpdfium-76c53794b6202ec37f6dcace5f2ae86870e953b6.tar.xz
Fix Wvarargs warning in XFA error code.chromium/2722chromium/2721chromium/2719chromium/2718
Chrome has enabled the -Wvarargs warning that was added to clang, this fails with PDFium XFA builds due to two warnings: ../../xfa/fxfa/fm2js/xfa_lexer.cpp:539:16: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs] va_start(ap, msg); ^ ../../xfa/fxfa/fm2js/xfa_lexer.cpp:535:40: note: parameter of type 'XFA_FM_ERRMSG' is declared here void CXFA_FMLexer::Error(XFA_FM_ERRMSG msg, ...) { The issue is that XFA_FM_ERRMSG is an enum and we violate the promotion rules for passing the value to va_start. I removed the enum and named the flags explicitly then pass in the string as the argument. BUG=chromium:606726 Review URL: https://codereview.chromium.org/1921323002
Diffstat (limited to 'build_gyp/standalone.gypi')
-rw-r--r--build_gyp/standalone.gypi5
1 files changed, 4 insertions, 1 deletions
diff --git a/build_gyp/standalone.gypi b/build_gyp/standalone.gypi
index 4b5b74072a..ad7ebdaac0 100644
--- a/build_gyp/standalone.gypi
+++ b/build_gyp/standalone.gypi
@@ -394,7 +394,10 @@
],
},
'variables': {
- 'clang_warning_flags': [],
+ 'clang_warning_flags': [
+ # TODO(thakis): https://crbug.com/604888
+ '-Wno-undefined-var-template',
+ ],
},
'includes': [ 'set_clang_warning_flags.gypi', ],
'conditions': [