diff options
| author | weili <weili@chromium.org> | 2016-05-27 17:58:23 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-05-27 17:58:23 -0700 |
| commit | dcc29b1f2eb66984a18d54e66851965472675006 (patch) | |
| tree | b2ee98c5944bf4d39f80fec6c94031d48065f710 /build_gyp | |
| parent | 3a005f22703b9303a306bf34cbd17c3729f763aa (diff) | |
| download | pdfium-dcc29b1f2eb66984a18d54e66851965472675006.tar.xz | |
Match GN and GYP compilation warning flags
For GN build:
Enable chromium_code compilation config for XFA code;
Remove sign-compare suppression;
Limit the strict-overflow warning suppression only to xfa target;
For GYP build:
Remove warning suppression 4800 from GYP non third-party code;
After this, all the warning flags and levels for GN and GYP
builds should match.
BUG=pdfium:29, pdfium:475
Review-Url: https://codereview.chromium.org/2011303003
Diffstat (limited to 'build_gyp')
| -rw-r--r-- | build_gyp/standalone.gypi | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/build_gyp/standalone.gypi b/build_gyp/standalone.gypi index f191c28e42..aa3feeaa10 100644 --- a/build_gyp/standalone.gypi +++ b/build_gyp/standalone.gypi @@ -205,8 +205,7 @@ # This section is PDFium specific. # #### - # C4800: forcing value to bool 'true' or 'false' (performance warning) - 4800, + # Now there is no PDFium specific flag. Add here if needed. # #### # This section should match Chromium's build/common.gypi. @@ -479,6 +478,10 @@ '-Wno-unused-variable', ], }, + 'msvs_disabled_warnings': [ + # forcing value to bool 'true' or 'false' (performance warning) + 4800, + ], 'msvs_settings': { 'VCCLCompilerTool': { 'WarningLevel': '3', |