diff options
author | Dan Sinclair <dsinclair@chromium.org> | 2017-05-10 13:54:54 -0400 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2017-05-10 19:40:30 +0000 |
commit | aa7022833db1a6e21b81fcca30b45ba652298f32 (patch) | |
tree | 2a24f3f64c57776b27155f742f77c8805aa5215f /core/fpdfapi/edit/cpdf_creator.h | |
parent | 2e2ee0e7f786dbc27a5b85b27d5e91e821069aea (diff) | |
download | pdfium-aa7022833db1a6e21b81fcca30b45ba652298f32.tar.xz |
Cleaning up Edit code
This Cl conslidates if statements, converts int returns to bools where
possible and various other cleanups in fpdfapi/edit.
Change-Id: Ia31ecc69843117eb5ebfff449a6046a267d08e89
Reviewed-on: https://pdfium-review.googlesource.com/5190
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fpdfapi/edit/cpdf_creator.h')
-rw-r--r-- | core/fpdfapi/edit/cpdf_creator.h | 35 |
1 files changed, 18 insertions, 17 deletions
diff --git a/core/fpdfapi/edit/cpdf_creator.h b/core/fpdfapi/edit/cpdf_creator.h index bda6507f21..5f39f5c40f 100644 --- a/core/fpdfapi/edit/cpdf_creator.h +++ b/core/fpdfapi/edit/cpdf_creator.h @@ -58,6 +58,10 @@ class CPDF_Creator { m_ObjectOffsets[objnum] = offset; } bool IsIncremental() const { return !!(m_dwFlags & FPDFCREATE_INCREMENTAL); } + bool IsOriginal() const { return !(m_dwFlags & FPDFCREATE_NO_ORIGINAL); } + bool HasObjectStream() const { + return !!(m_dwFlags & FPDFCREATE_OBJECTSTREAM); + } private: void Clear(); @@ -66,29 +70,26 @@ class CPDF_Creator { void InitNewObjNumOffsets(); void InitID(); - int32_t AppendObjectNumberToXRef(uint32_t objnum); + bool AppendObjectNumberToXRef(uint32_t objnum); int32_t WriteDoc_Stage1(); int32_t WriteDoc_Stage2(); int32_t WriteDoc_Stage3(); int32_t WriteDoc_Stage4(); - int32_t WriteOldIndirectObject(uint32_t objnum); - int32_t WriteOldObjs(); - int32_t WriteNewObjs(); - int32_t WriteIndirectObj(const CPDF_Object* pObj); - int32_t WriteDirectObj(uint32_t objnum, - const CPDF_Object* pObj, - bool bEncrypt); - int32_t WriteIndirectObjectToStream(const CPDF_Object* pObj); - int32_t WriteIndirectObj(uint32_t objnum, const CPDF_Object* pObj); - int32_t WriteIndirectObjectToStream(uint32_t objnum, - const uint8_t* pBuffer, - uint32_t dwSize); - - int32_t WriteStream(const CPDF_Object* pStream, - uint32_t objnum, - CPDF_CryptoHandler* pCrypto); + bool WriteOldIndirectObject(uint32_t objnum); + bool WriteOldObjs(); + bool WriteNewObjs(); + bool WriteIndirectObj(const CPDF_Object* pObj); + bool WriteDirectObj(uint32_t objnum, const CPDF_Object* pObj, bool bEncrypt); + bool WriteIndirectObj(uint32_t objnum, const CPDF_Object* pObj); + bool WriteIndirectObjectToStream(uint32_t objnum, + const uint8_t* pBuffer, + uint32_t dwSize); + + bool WriteStream(const CPDF_Object* pStream, + uint32_t objnum, + CPDF_CryptoHandler* pCrypto); bool IsXRefNeedEnd(); |