diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-06-21 15:02:24 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-06-21 15:02:24 +0000 |
| commit | 9c292fef316739f43730f11b9a2b6d3e4b725b54 (patch) | |
| tree | e286b6c7a36c50eba235c7b69b30b95fc36cb906 /core/fpdfapi/font | |
| parent | bcd66f54de1291ddf8b7b7caca3e7360e14fcc8d (diff) | |
| download | pdfium-9c292fef316739f43730f11b9a2b6d3e4b725b54.tar.xz | |
Avoid const-refs to implicitly constructed strings.
Because the invisible temporary goes out of scope at the next
semicolon.
Also avoid returning const string references since the cost is
low to properly keep the string alive.
Change-Id: Id283e4fd99f79a02d79d739a533a4ce05e831e2a
Reviewed-on: https://pdfium-review.googlesource.com/35710
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fpdfapi/font')
| -rw-r--r-- | core/fpdfapi/font/cpdf_font.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/fpdfapi/font/cpdf_font.h b/core/fpdfapi/font/cpdf_font.h index a137879891..4b099ae0d0 100644 --- a/core/fpdfapi/font/cpdf_font.h +++ b/core/fpdfapi/font/cpdf_font.h @@ -63,7 +63,7 @@ class CPDF_Font { virtual uint32_t CharCodeFromUnicode(wchar_t Unicode) const; virtual bool HasFontWidths() const; - const ByteString& GetBaseFont() const { return m_BaseFont; } + ByteString GetBaseFont() const { return m_BaseFont; } CFX_SubstFont* GetSubstFont() const { return m_Font.GetSubstFont(); } bool IsEmbedded() const { return IsType3Font() || m_pFontFile != nullptr; } const CPDF_Dictionary* GetFontDict() const { return m_pFontDict; } |