diff options
| author | tsepez <tsepez@chromium.org> | 2016-04-11 18:14:56 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-04-11 18:14:56 -0700 |
| commit | 822484b5f88d92dbcd567b1c2da38af1e720b56f (patch) | |
| tree | de1902c744cbe38023432cc3f860d99df90beb70 /core/fpdfapi/fpdf_parser/include/cpdf_object.h | |
| parent | e09c1e4db92e28a332f55aa3c80ceb44f4b74287 (diff) | |
| download | pdfium-822484b5f88d92dbcd567b1c2da38af1e720b56f.tar.xz | |
Remove CPDF_Object::GetConstString and overrides
GetConstString() has sharp edges in that when applied to
a CPDF_Number, it must return null whereas GetString() returns
a the stringified number, because of the inability to
control the lifetime of the underlying allocated string.
Deleting this method showed several places where we
actually wanted a *String, not a *StringC, so we were
re-allocating a string we already had.
Review URL: https://codereview.chromium.org/1879683002
Diffstat (limited to 'core/fpdfapi/fpdf_parser/include/cpdf_object.h')
| -rw-r--r-- | core/fpdfapi/fpdf_parser/include/cpdf_object.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_object.h b/core/fpdfapi/fpdf_parser/include/cpdf_object.h index 6cdaaf58fd..c0c442157f 100644 --- a/core/fpdfapi/fpdf_parser/include/cpdf_object.h +++ b/core/fpdfapi/fpdf_parser/include/cpdf_object.h @@ -46,9 +46,6 @@ class CPDF_Object { void Release(); virtual CFX_ByteString GetString() const; - - // Note: |this| must outlive the use of |GetConstString|'s result. - virtual CFX_ByteStringC GetConstString() const; virtual CFX_WideString GetUnicodeText() const; virtual FX_FLOAT GetNumber() const; virtual int GetInteger() const; |