diff options
| author | weili <weili@chromium.org> | 2016-05-16 13:53:42 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-05-16 13:53:42 -0700 |
| commit | 3cc01f2ba255f4b7584668ee2b8e5ed97792c26d (patch) | |
| tree | 6a207d8910696ef1c28ef60a855ae266f81067cd /core/fpdfapi/fpdf_parser | |
| parent | c6450bb06b69528406a2a261c70c4ea769965a8d (diff) | |
| download | pdfium-3cc01f2ba255f4b7584668ee2b8e5ed97792c26d.tar.xz | |
Fix the code that causes warnings
These are the left or newly added code which causes compilation
warnings of "signed and unsigned comparison". Need to fix them
before I re-enable the warning flag.
BUG=pdfium:29
Review-Url: https://codereview.chromium.org/1986533002
Diffstat (limited to 'core/fpdfapi/fpdf_parser')
| -rw-r--r-- | core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp | 2 | ||||
| -rw-r--r-- | core/fpdfapi/fpdf_parser/cpdf_document.cpp | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp b/core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp index 58642a610f..12a36d921a 100644 --- a/core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp +++ b/core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp @@ -76,7 +76,7 @@ TEST(cpdf_array, InsertAt) { for (size_t i = 0; i < FX_ArraySize(elems); ++i) arr->InsertAt(i, new CPDF_Number(elems[i])); arr->InsertAt(10, new CPDF_Number(10)); - EXPECT_EQ(11, arr->GetCount()); + EXPECT_EQ(11u, arr->GetCount()); for (size_t i = 0; i < FX_ArraySize(elems); ++i) EXPECT_EQ(elems[i], arr->GetIntegerAt(i)); for (size_t i = FX_ArraySize(elems); i < 10; ++i) diff --git a/core/fpdfapi/fpdf_parser/cpdf_document.cpp b/core/fpdfapi/fpdf_parser/cpdf_document.cpp index 52899eedb3..13d9737b5b 100644 --- a/core/fpdfapi/fpdf_parser/cpdf_document.cpp +++ b/core/fpdfapi/fpdf_parser/cpdf_document.cpp @@ -1102,7 +1102,7 @@ CPDF_Font* CPDF_Document::AddWindowsFont(LOGFONTA* pLogFont, pBaseDict->SetAtName("Encoding", "WinAnsiEncoding"); } else { flags |= PDFFONT_NONSYMBOLIC; - int i; + size_t i; for (i = 0; i < FX_ArraySize(g_FX_CharsetUnicodes); ++i) { if (g_FX_CharsetUnicodes[i].m_Charset == pLogFont->lfCharSet) break; @@ -1136,7 +1136,7 @@ CPDF_Font* CPDF_Document::AddWindowsFont(LOGFONTA* pLogFont, int char_widths[224]; GetCharWidth(hDC, 32, 255, char_widths); CPDF_Array* pWidths = new CPDF_Array; - for (int i = 0; i < 224; i++) + for (size_t i = 0; i < 224; i++) pWidths->AddInteger(char_widths[i]); pBaseDict->SetAt("Widths", pWidths); |