diff options
author | Lei Zhang <thestig@chromium.org> | 2017-04-26 15:22:00 -0700 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2017-04-27 23:22:12 +0000 |
commit | 66568bcd683dd7b18672cb3aebca4487e9203519 (patch) | |
tree | 7297841771a796bafd3d0d17dd47b7b0e394d933 /core/fpdfapi/page/cpdf_color.cpp | |
parent | ba817506edcb26e0acf497111e7684e39dadaf04 (diff) | |
download | pdfium-66568bcd683dd7b18672cb3aebca4487e9203519.tar.xz |
Assert CPDF_Pattern always has a valid CPDF_Document pointer.
Same for CPDF_DocPageData.
Change-Id: I8f2f559123dbb2f3623d957e4074d5f9d191797f
Reviewed-on: https://pdfium-review.googlesource.com/4501
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core/fpdfapi/page/cpdf_color.cpp')
-rw-r--r-- | core/fpdfapi/page/cpdf_color.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/core/fpdfapi/page/cpdf_color.cpp b/core/fpdfapi/page/cpdf_color.cpp index 59ce6dab28..6e772aadb1 100644 --- a/core/fpdfapi/page/cpdf_color.cpp +++ b/core/fpdfapi/page/cpdf_color.cpp @@ -31,7 +31,7 @@ void CPDF_Color::ReleaseBuffer() { PatternValue* pvalue = (PatternValue*)m_pBuffer; CPDF_Pattern* pPattern = pvalue->m_pCountedPattern ? pvalue->m_pCountedPattern->get() : nullptr; - if (pPattern && pPattern->document()) { + if (pPattern) { CPDF_DocPageData* pPageData = pPattern->document()->GetPageData(); if (pPageData) pPageData->ReleasePattern(pPattern->pattern_obj()); @@ -89,7 +89,7 @@ void CPDF_Color::SetValue(CPDF_Pattern* pPattern, float* comps, int ncomps) { CPDF_DocPageData* pDocPageData = nullptr; PatternValue* pvalue = (PatternValue*)m_pBuffer; - if (pvalue->m_pPattern && pvalue->m_pPattern->document()) { + if (pvalue->m_pPattern) { pDocPageData = pvalue->m_pPattern->document()->GetPageData(); if (pDocPageData) pDocPageData->ReleasePattern(pvalue->m_pPattern->pattern_obj()); @@ -100,7 +100,7 @@ void CPDF_Color::SetValue(CPDF_Pattern* pPattern, float* comps, int ncomps) { memcpy(pvalue->m_Comps, comps, ncomps * sizeof(float)); pvalue->m_pCountedPattern = nullptr; - if (pPattern && pPattern->document()) { + if (pPattern) { if (!pDocPageData) pDocPageData = pPattern->document()->GetPageData(); @@ -129,7 +129,7 @@ void CPDF_Color::Copy(const CPDF_Color* pSrc) { PatternValue* pValue = reinterpret_cast<PatternValue*>(m_pBuffer); CPDF_Pattern* pPattern = pValue->m_pPattern; - if (pPattern && pPattern->document()) { + if (pPattern) { pValue->m_pPattern = pPattern->document()->GetPageData()->GetPattern( pPattern->pattern_obj(), false, pPattern->parent_matrix()); } |