diff options
| author | Lei Zhang <thestig@chromium.org> | 2018-04-12 20:58:56 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-04-12 20:58:56 +0000 |
| commit | 2772a2d944c8573aa187339b0b5ea059d1293c36 (patch) | |
| tree | 6093cb350e78c64ce32fe2c7a433258f70c1ad58 /core/fpdfapi/page/cpdf_color.h | |
| parent | 9e625db795ca7e112d692bda7200b69a873d75f7 (diff) | |
| download | pdfium-2772a2d944c8573aa187339b0b5ea059d1293c36.tar.xz | |
More CPDF_Color improvements.
Make Copy() take a const-ref parameter. As is, the parameter is a
pointer and it is dereferenced without any checks, and there are no
crash reports as a result of that.
Also mention GetPattern() should only be called when IsPattern() returns
true.
Change-Id: Ice3b7c941532d5a312fdd8f0c032e08d1ee1c6b5
Reviewed-on: https://pdfium-review.googlesource.com/30430
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core/fpdfapi/page/cpdf_color.h')
| -rw-r--r-- | core/fpdfapi/page/cpdf_color.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/core/fpdfapi/page/cpdf_color.h b/core/fpdfapi/page/cpdf_color.h index 2eac7cfacb..31bc125d83 100644 --- a/core/fpdfapi/page/cpdf_color.h +++ b/core/fpdfapi/page/cpdf_color.h @@ -20,14 +20,17 @@ class CPDF_Color { bool IsNull() const { return !m_pBuffer; } bool IsPattern() const; - void Copy(const CPDF_Color* pSrc); + void Copy(const CPDF_Color& src); void SetColorSpace(CPDF_ColorSpace* pCS); void SetValue(const float* comp); void SetValue(CPDF_Pattern* pPattern, const float* comp, uint32_t ncomps); bool GetRGB(int* R, int* G, int* B) const; + + // Should only be called if IsPattern() returns true. CPDF_Pattern* GetPattern() const; + const CPDF_ColorSpace* GetColorSpace() const { return m_pCS; } protected: |