More CPDF_Color improvements.

Make Copy() take a const-ref parameter. As is, the parameter is a
pointer and it is dereferenced without any checks, and there are no
crash reports as a result of that.

Also mention GetPattern() should only be called when IsPattern() returns
true.

Change-Id: Ice3b7c941532d5a312fdd8f0c032e08d1ee1c6b5
Reviewed-on: https://pdfium-review.googlesource.com/30430
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

1 files changed, 2 insertions, 2 deletions

diff --git a/core/fpdfapi/page/cpdf_colorstate.cpp b/core/fpdfapi/page/cpdf_colorstate.cpp
index 227fd62045..b1f14c88b1 100644
--- a/core/fpdfapi/page/cpdf_colorstate.cpp
+++ b/core/fpdfapi/page/cpdf_colorstate.cpp
@@ -147,8 +147,8 @@ CPDF_ColorState::ColorData::ColorData()
 CPDF_ColorState::ColorData::ColorData(const ColorData& src)
     : m_FillColorRef(src.m_FillColorRef),
       m_StrokeColorRef(src.m_StrokeColorRef) {
-  m_FillColor.Copy(&src.m_FillColor);
-  m_StrokeColor.Copy(&src.m_StrokeColor);
+  m_FillColor.Copy(src.m_FillColor);
+  m_StrokeColor.Copy(src.m_StrokeColor);
 }
 
 CPDF_ColorState::ColorData::~ColorData() {}