diff options
| author | Henrique Nakashima <hnakashima@chromium.org> | 2018-07-06 17:38:36 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-07-06 17:38:36 +0000 |
| commit | 05aa09d3ebfd587dd8e1116b6cac8053a2944a1a (patch) | |
| tree | c8164acbc6422ad8177a111682025c7e0e90e081 /core/fpdfapi/page/cpdf_contentmarkitem.cpp | |
| parent | dd1083b47c029d2540aceb246bf80f549781f62f (diff) | |
| download | pdfium-05aa09d3ebfd587dd8e1116b6cac8053a2944a1a.tar.xz | |
Make MarkData::mMarks a vector of RetainPtr<CPDF_ContentMarkItem>
It is currently a vector of CPDF_ContentMarkItem.
Copying MarkData whenever a content mark is opened or closed is
inefficient since each MarkData will have copies of the same
CPDF_ContentMarkItems.
This CL changes the vector inside MarkData to contains only pointers
to the CPDF_ContentMarkItems rather than copies of those items. More
importantly, this unifies the dictionaries of each content mark.
Previously, there were as many copies of those dictionaries as content
marks scope changes inside the mark with parameters.
Bug: pdfium:1037
Change-Id: Ia6f79b401d4e14ac07dbba81bbd97df965b77c94
Reviewed-on: https://pdfium-review.googlesource.com/37135
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'core/fpdfapi/page/cpdf_contentmarkitem.cpp')
| -rw-r--r-- | core/fpdfapi/page/cpdf_contentmarkitem.cpp | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/core/fpdfapi/page/cpdf_contentmarkitem.cpp b/core/fpdfapi/page/cpdf_contentmarkitem.cpp index 205f14de35..4f56eea919 100644 --- a/core/fpdfapi/page/cpdf_contentmarkitem.cpp +++ b/core/fpdfapi/page/cpdf_contentmarkitem.cpp @@ -12,14 +12,6 @@ CPDF_ContentMarkItem::CPDF_ContentMarkItem() {} -CPDF_ContentMarkItem::CPDF_ContentMarkItem(const CPDF_ContentMarkItem& that) - : m_MarkName(that.m_MarkName), - m_ParamType(that.m_ParamType), - m_pPropertiesDict(that.m_pPropertiesDict) { - if (that.m_pDirectDict) - m_pDirectDict = ToDictionary(that.m_pDirectDict->Clone()); -} - CPDF_ContentMarkItem::~CPDF_ContentMarkItem() {} const CPDF_Dictionary* CPDF_ContentMarkItem::GetParam() const { |