Fix nits in CPDF_Function and derived classes.

- Switch away from FX_Alloc2D() when it is safe to do so.
- Use FX_SAFE_SIZE_T to avoid a potential underflow with FX_Realloc().
- Mark the v_Call() input as const.
- Check Call() and v_Call() return results.

Change-Id: I6ec3122b23e0f137f88aa8d85a9675154a1b1706
Reviewed-on: https://pdfium-review.googlesource.com/30802
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

1 files changed, 3 insertions, 1 deletions

diff --git a/core/fpdfapi/page/cpdf_function.h b/core/fpdfapi/page/cpdf_function.h
index 615c6a68d4..82a3a54327 100644
--- a/core/fpdfapi/page/cpdf_function.h
+++ b/core/fpdfapi/page/cpdf_function.h
@@ -55,12 +55,14 @@ class CPDF_Function {
                                              std::set<CPDF_Object*>* pVisited);
   bool Init(CPDF_Object* pObj, std::set<CPDF_Object*>* pVisited);
   virtual bool v_Init(CPDF_Object* pObj, std::set<CPDF_Object*>* pVisited) = 0;
-  virtual bool v_Call(float* inputs, float* results) const = 0;
+  virtual bool v_Call(const float* inputs, float* results) const = 0;
 
   uint32_t m_nInputs;
   uint32_t m_nOutputs;
   float* m_pDomains;
   float* m_pRanges;
+
+ private:
   const Type m_Type;
 };