diff options
author | Tom Sepez <tsepez@chromium.org> | 2018-04-06 23:48:24 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-04-06 23:48:24 +0000 |
commit | 6058efdbdc186e120e7e2121c290ac4d820ffbf8 (patch) | |
tree | 8944872de2d924d3efd76266cc929c6f25199134 /core/fpdfapi/page/cpdf_streamparser_unittest.cpp | |
parent | 2aa01f5ccbf1464b43527c1ffa6b42bafed9ebeb (diff) | |
download | pdfium-6058efdbdc186e120e7e2121c290ac4d820ffbf8.tar.xz |
Add span.h from chromium base.chromium/3392
Allows indexing with better bounds-checking to occur. Some small
modifications are required to deal with PDFium being intentionally
held at C++11 compliance, not C++14.
Use in one place as check on correctness.
Change-Id: Id2875cf0a93980112bc536a93c4f9ec5306c0dac
Reviewed-on: https://pdfium-review.googlesource.com/29671
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fpdfapi/page/cpdf_streamparser_unittest.cpp')
-rw-r--r-- | core/fpdfapi/page/cpdf_streamparser_unittest.cpp | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/core/fpdfapi/page/cpdf_streamparser_unittest.cpp b/core/fpdfapi/page/cpdf_streamparser_unittest.cpp index 40a41befe1..d83fedcb7d 100644 --- a/core/fpdfapi/page/cpdf_streamparser_unittest.cpp +++ b/core/fpdfapi/page/cpdf_streamparser_unittest.cpp @@ -4,12 +4,13 @@ #include "core/fpdfapi/page/cpdf_streamparser.h" #include "testing/gtest/include/gtest/gtest.h" +#include "third_party/base/span.h" TEST(cpdf_streamparser, ReadHexString) { { // Position out of bounds. uint8_t data[] = "12ab>"; - CPDF_StreamParser parser(data, 5); + CPDF_StreamParser parser(data); parser.SetPos(6); EXPECT_EQ("", parser.ReadHexString()); } @@ -17,7 +18,7 @@ TEST(cpdf_streamparser, ReadHexString) { { // Regular conversion. uint8_t data[] = "1A2b>abcd"; - CPDF_StreamParser parser(data, 5); + CPDF_StreamParser parser(data); EXPECT_EQ("\x1a\x2b", parser.ReadHexString()); EXPECT_EQ(5u, parser.GetPos()); } @@ -25,7 +26,7 @@ TEST(cpdf_streamparser, ReadHexString) { { // Missing ending > uint8_t data[] = "1A2b"; - CPDF_StreamParser parser(data, 5); + CPDF_StreamParser parser(data); EXPECT_EQ("\x1a\x2b", parser.ReadHexString()); EXPECT_EQ(5u, parser.GetPos()); } @@ -33,14 +34,14 @@ TEST(cpdf_streamparser, ReadHexString) { { // Uneven number of bytes. uint8_t data[] = "1A2>asdf"; - CPDF_StreamParser parser(data, 5); + CPDF_StreamParser parser(data); EXPECT_EQ("\x1a\x20", parser.ReadHexString()); EXPECT_EQ(4u, parser.GetPos()); } { uint8_t data[] = ">"; - CPDF_StreamParser parser(data, 5); + CPDF_StreamParser parser(data); EXPECT_EQ("", parser.ReadHexString()); EXPECT_EQ(1u, parser.GetPos()); } |