Clean up fpdf_page_parsers

- The code in fpdf_page_parser is only called by CPDF_StreamContentParser, so moved there.
- Split fpdf_page_parser_old into its two classes
- Renamed the corresponding unittests accordingly.
- Moved PDF_ReplaceAbbr to namespace
- Fixed few nits
- Added TODO because CPDF_StreamParser has a lot of code similar to CPDF_SyntaxParser

Review-Url: https://codereview.chromium.org/2474303003

1 files changed, 0 insertions, 34 deletions

diff --git a/core/fpdfapi/page/fpdf_page_parser_unittest.cpp b/core/fpdfapi/page/fpdf_page_parser_unittest.cpp
deleted file mode 100644
index b6eec7bcf7..0000000000
--- a/core/fpdfapi/page/fpdf_page_parser_unittest.cpp
+++ /dev/null
@@ -1,34 +0,0 @@
-// Copyright 2016 PDFium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "core/fpdfapi/page/pageint.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-TEST(fpdf_page_parser, PDF_FindKeyAbbreviation) {
-  EXPECT_EQ(CFX_ByteStringC("BitsPerComponent"),
-            PDF_FindKeyAbbreviationForTesting(CFX_ByteStringC("BPC")));
-  EXPECT_EQ(CFX_ByteStringC("Width"),
-            PDF_FindKeyAbbreviationForTesting(CFX_ByteStringC("W")));
-  EXPECT_EQ(CFX_ByteStringC(""),
-            PDF_FindKeyAbbreviationForTesting(CFX_ByteStringC("")));
-  EXPECT_EQ(CFX_ByteStringC(""),
-            PDF_FindKeyAbbreviationForTesting(CFX_ByteStringC("NoInList")));
-  // Prefix should not match.
-  EXPECT_EQ(CFX_ByteStringC(""),
-            PDF_FindKeyAbbreviationForTesting(CFX_ByteStringC("WW")));
-}
-
-TEST(fpdf_page_parser, PDF_FindValueAbbreviation) {
-  EXPECT_EQ(CFX_ByteStringC("DeviceGray"),
-            PDF_FindValueAbbreviationForTesting(CFX_ByteStringC("G")));
-  EXPECT_EQ(CFX_ByteStringC("DCTDecode"),
-            PDF_FindValueAbbreviationForTesting(CFX_ByteStringC("DCT")));
-  EXPECT_EQ(CFX_ByteStringC(""),
-            PDF_FindValueAbbreviationForTesting(CFX_ByteStringC("")));
-  EXPECT_EQ(CFX_ByteStringC(""),
-            PDF_FindValueAbbreviationForTesting(CFX_ByteStringC("NoInList")));
-  // Prefix should not match.
-  EXPECT_EQ(CFX_ByteStringC(""),
-            PDF_FindValueAbbreviationForTesting(CFX_ByteStringC("II")));
-}