Move ToString() and friends from CPDF_Object.h to CPDF_String.h

Ditto with the other ToXXX functions to CPDF_xxx.h.

Shortly, we will want to introduce another variant:
  inline std::unique_ptr<CPDF_String> ToString(
      std::unique_ptr<CPDF_Object>);

This will require that CPDF_String be complete which is
not the case in the CPDF_Object.h header.  Rather than
dragging all the other .h's into it, move these to the
subclass headers.  That way, these will be together
when the new form is added.

Review-Url: https://codereview.chromium.org/2406033002

1 files changed, 8 insertions, 0 deletions

diff --git a/core/fpdfapi/parser/cpdf_dictionary.h b/core/fpdfapi/parser/cpdf_dictionary.h
index b56e40a6ef..9cf575ddd4 100644
--- a/core/fpdfapi/parser/cpdf_dictionary.h
+++ b/core/fpdfapi/parser/cpdf_dictionary.h
@@ -98,4 +98,12 @@ class CPDF_Dictionary : public CPDF_Object {
   std::map<CFX_ByteString, CPDF_Object*> m_Map;
 };
 
+inline CPDF_Dictionary* ToDictionary(CPDF_Object* obj) {
+  return obj ? obj->AsDictionary() : nullptr;
+}
+
+inline const CPDF_Dictionary* ToDictionary(const CPDF_Object* obj) {
+  return obj ? obj->AsDictionary() : nullptr;
+}
+
 #endif  // CORE_FPDFAPI_PARSER_CPDF_DICTIONARY_H_