diff options
author | tsepez <tsepez@chromium.org> | 2016-11-04 15:45:02 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-11-04 15:45:03 -0700 |
commit | 1d08c50d1c20798001a1944e8a1fd76d09643ef1 (patch) | |
tree | 062d248591c5b201f00a50c09995e94c09794bc2 /core/fpdfapi/parser/cpdf_indirect_object_holder.cpp | |
parent | c5267c54ea32ade03bf10e6bb203e34e3fcbd77d (diff) | |
download | pdfium-1d08c50d1c20798001a1944e8a1fd76d09643ef1.tar.xz |
CHECK for re-addition of indirect objects
Review-Url: https://codereview.chromium.org/2471263005
Diffstat (limited to 'core/fpdfapi/parser/cpdf_indirect_object_holder.cpp')
-rw-r--r-- | core/fpdfapi/parser/cpdf_indirect_object_holder.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp b/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp index d3204e04e5..720fe18606 100644 --- a/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp +++ b/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp @@ -43,9 +43,7 @@ CPDF_Object* CPDF_IndirectObjectHolder::ParseIndirectObject(uint32_t objnum) { } uint32_t CPDF_IndirectObjectHolder::AddIndirectObject(CPDF_Object* pObj) { - if (pObj->m_ObjNum) - return pObj->m_ObjNum; - + CHECK(!pObj->m_ObjNum); m_LastObjNum++; m_IndirectObjs[m_LastObjNum].release(); // TODO(tsepez): stop this leak. m_IndirectObjs[m_LastObjNum].reset(pObj); |