diff options
| author | Tom Sepez <tsepez@chromium.org> | 2017-02-16 12:20:13 -0800 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-02-16 21:37:53 +0000 |
| commit | 28e691995a7d14f3001eede5f00f62b9a64d8a69 (patch) | |
| tree | 0a52cef81980fd00cfa2b0b484dd5442d056f313 /core/fpdfapi/parser/cpdf_indirect_object_holder.cpp | |
| parent | d6ae2afa821c87e84790d5c04bbc172a7b12f08f (diff) | |
| download | pdfium-28e691995a7d14f3001eede5f00f62b9a64d8a69.tar.xz | |
Avoid a potential leak in CPDF_IndirectObjectHolder
Keep a vector of object superseeded by another object. These will
no longer be returned from the holder, but it will clean them
Change-Id: If9754ff6614bd79e9de6ce8c3492230435813218
Reviewed-on: https://pdfium-review.googlesource.com/2790
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fpdfapi/parser/cpdf_indirect_object_holder.cpp')
| -rw-r--r-- | core/fpdfapi/parser/cpdf_indirect_object_holder.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp b/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp index ef3de92f76..3037d0b9b5 100644 --- a/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp +++ b/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp @@ -56,7 +56,9 @@ CPDF_Object* CPDF_IndirectObjectHolder::AddIndirectObject( CHECK(!pObj->m_ObjNum); CPDF_Object* pUnowned = pObj.get(); pObj->m_ObjNum = ++m_LastObjNum; - m_IndirectObjs[m_LastObjNum].release(); // TODO(tsepez): stop this leak. + if (m_IndirectObjs[m_LastObjNum]) + m_OrphanObjs.push_back(std::move(m_IndirectObjs[m_LastObjNum])); + m_IndirectObjs[m_LastObjNum] = std::move(pObj); return pUnowned; } |